Skip to content

{AKS} support disabling Azure KeyVault KMS - #5087

Merged
Xing Zhou (zhoxing-ms) merged 1 commit into
Azure:mainfrom
bingosummer:aks-disable-kms
Jul 25, 2022
Merged

Xing Zhou (zhoxing-ms) merged 1 commit into
Azure:mainfrom
bingosummer:aks-disable-kms

Conversation

@bingosummer

@bingosummer Bin Xia (bingosummer) commented Jul 6, 2022 •

Copy link
Copy Markdown
Member
  • Add a new parameter --disable-azure-keyvault-kms for az aks update.
  • Add tests for disabling KMS.

@ghost ghost added this to the Jul 2022 (2022-08-02) milestone Jul 6, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Jul 6, 2022
@ghost
ghost requested a review from Yong Zhang (yonzhan) July 6, 2022 07:31
@ghost ghost added the AKS label Jul 6, 2022
@yonzhan

Copy link
Copy Markdown
Collaborator

AKS

@bingosummer
Bin Xia (bingosummer) force-pushed the aks-disable-kms branch 3 times, most recently from 5dd57a4 to b6125dd Compare July 7, 2022 03:45
Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated
@bingosummer
Bin Xia (bingosummer) force-pushed the aks-disable-kms branch 3 times, most recently from f7d6701 to 5eff54f Compare July 11, 2022 14:24
@bingosummer

Copy link
Copy Markdown
Member Author

FumingZhang please have a review, thanks!

@FumingZhang FumingZhang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingosummer

Copy link
Copy Markdown
Member Author

Xing Zhou (@zhoxing-ms) could you please review and merge the PR? Thanks

@zhoxing-ms
Xing Zhou (zhoxing-ms) merged commit ca8d23c into Azure:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants