Repository navigation
[AKS] Trusted Access Role Binding CLI - #4955
Merged
Merged
Conversation
Yitong Feng (YitongFeng-git)
requested review from
FumingZhang and
Liming Liu (andyliuliming)
as code owners
June 8, 2022 03:49
ghost
assigned
ghost
requested a review
from Yong Zhang (yonzhan)
June 8, 2022 03:49
Collaborator
|
AKS |
Yitong Feng (YitongFeng-git)
force-pushed
the
yife/binding
branch
7 times, most recently
from
June 9, 2022 02:25
b920784 to
e1ee74e
Compare
FumingZhang
reviewed
Jun 9, 2022
FumingZhang
left a comment
FumingZhang
left a comment
Member
There was a problem hiding this comment.
Is the format change caused by LF -> CRLF?
Yitong Feng (YitongFeng-git)
force-pushed
the
yife/binding
branch
4 times, most recently
from
June 9, 2022 05:47
1f0ad60 to
ea52c98
Compare
FumingZhang
reviewed
Jun 9, 2022
Yitong Feng (YitongFeng-git)
force-pushed
the
yife/binding
branch
2 times, most recently
from
June 9, 2022 07:28
14f8797 to
62c278c
Compare
Contributor
|
Could you add some tests for those new commands? |
FumingZhang
reviewed
Jun 10, 2022
Member
The resource has not been deployed to prod regions so currently there's no way to test the commands. |
Yitong Feng (YitongFeng-git)
force-pushed
the
yife/binding
branch
3 times, most recently
from
June 13, 2022 05:17
05aa9f8 to
1c8b55f
Compare
Dong Liu (karataliu)
approved these changes
Jun 13, 2022
Yitong Feng (YitongFeng-git)
force-pushed
the
yife/binding
branch
from
June 13, 2022 06:47
1c8b55f to
d131117
Compare
ZelinWang (wangzelin007)
approved these changes
Jun 13, 2022
Contributor
|
ZelinWang (@wangzelin007) Xing Zhou (@zhoxing-ms) could you help a merge? |
Xing Zhou (zhoxing-ms)
approved these changes
Jun 14, 2022
Xing Zhou (zhoxing-ms)
left a comment
Xing Zhou (zhoxing-ms)
left a comment
Contributor
There was a problem hiding this comment.
The resource has not been deployed to prod regions so currently there's no way to test the commands.
Please supplement relevant tests in the future PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.Test
Commands:
az aks trustedaccess rolebinding create -g yifetest --cluster-name yifeaks -n binding1 -s /subscriptions/8ecadfc9-d1a3-4ea4-b844-0d9f87e4d7c8/resourceGroups/yifetest/providers/Microsoft.MachineLearningServices/workspaces/yifeAML --roles Microsoft.MachineLearningServices/workspaces/reader Microsoft.MachineLearningServices/workspaces/writeraz aks trustedaccess rolebinding list -g yifetest --cluster-name yifeaksaz aks trustedaccess rolebinding show -g yifetest --cluster-name yifeaks -n binding1az aks trustedaccess rolebinding delete -g yifetest --cluster-name yifeaks -n binding1