Repository navigation
[AKS]fix: don't update storageProfile if not set - #4817
Merged
Merged
Conversation
Andy Zhang (andyzhangx)
requested review from
FumingZhang and
Liming Liu (andyliuliming)
as code owners
May 14, 2022 11:24
ghost
assigned
ghost
requested a review
from Yong Zhang (yonzhan)
May 14, 2022 11:25
Andy Zhang (andyzhangx)
changed the title
Update decorator.py Update decorator.py
fix test failure
Andy Zhang (andyzhangx)
force-pushed
the
patch-1
branch
from
May 14, 2022 12:34
ba31984 to
2a88217
Compare
Collaborator
|
AKS |
Update decorator.py Update decorator.py
fix test failure
Signed-off-by: Ji An Liu <jiliu8@microsoft.com>
Ji'an Liu (ZeroMagic)
force-pushed
the
patch-1
branch
from
May 16, 2022 01:18
2a88217 to
6f4ae96
Compare
Andy Zhang (andyzhangx)
force-pushed
the
patch-1
branch
from
May 16, 2022 02:48
1aafeb0 to
657106b
Compare
FumingZhang
reviewed
May 16, 2022
FumingZhang
left a comment
FumingZhang
left a comment
Member
There was a problem hiding this comment.
LGTM
Queued a pipeline to check the modified test cases.
FumingZhang
approved these changes
May 16, 2022
FumingZhang
left a comment
FumingZhang
left a comment
Member
There was a problem hiding this comment.
Live test passed. LGTM:shipit:
Xing Zhou (zhoxing-ms)
approved these changes
May 16, 2022
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FumingZhang
added a commit
to FumingZhang/azure-cli-extensions
that referenced
this pull request
May 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update
This PR fixed the issue that CSI driver would be accidentally disabled when run
az aks updatecommand even--disable-disk-driver --disable-file-driveris not specified.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.