Repository navigation
{AKS} Keep aad profile in PUT request of ManagedCluster - #4638
Merged
FumingZhang merged 4 commits intoApr 7, 2022
Merged
FumingZhang merged 4 commits into
FumingZhang merged 4 commits into
Conversation
ghost
assigned
FumingZhang
force-pushed
the
fuming/fix-upgrade-missing-aad-profile-0406
branch
from
April 6, 2022 09:05
304781e to
a6f2086
Compare
Collaborator
|
AKS |
FumingZhang
changed the title
aks upgrade, keep aad profile in upgrade request
FumingZhang
marked this pull request as ready for review
April 7, 2022 06:37
Bin Xia (bingosummer)
approved these changes
Apr 7, 2022
Xing Zhou (zhoxing-ms)
approved these changes
Apr 7, 2022
ZelinWang (wangzelin007)
approved these changes
Apr 7, 2022
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
BugFix: Keep aad profile in PUT request of ManagedCluster. Modified commands are
az aks scaleaz aks upgradeaz aks enable-addonsaz aks disable-addonsaz aks addon enableaz aks addon disableaz aks addon updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.