Repository navigation
[Quantum] Output job progress messages with Knack logger - #4632
Merged
kai ru (kairu-ms) merged 3 commits intoApr 12, 2022
Merged
Conversation
ghost
added
the 
ghost
requested a review
from Yong Zhang (yonzhan)
April 5, 2022 17:58
ghost
requested a review
from ZelinWang (wangzelin007)
April 5, 2022 17:58
Andres Paz (anpaz)
approved these changes
Apr 5, 2022
Warren Jones (warren-jones)
changed the title
Warren Jones (warren-jones)
marked this pull request as ready for review
April 5, 2022 21:52
Collaborator
|
Quantum |
kai ru (kairu-ms)
approved these changes
Apr 12, 2022
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The job submission progress messages added for PR 4480 broke the CLI integration tests in the E2E validation pipeline. Only JSON output is expected in stdout during the tests. By using the Knack logger and displaying the messages as warnings, the progress messages are output to stderr instead of stdout in a way that PowerShell will not treat them as errors.
Also updated test_version_check in test_quantum_workspace.py to remediate another E2E validation pipeline test failure.
This checklist is used to make sure that common guidelines for a pull request are followed.
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?