Skip to content

implement aks gpu instance profile - #3895

Merged
Xing Zhou (zhoxing-ms) merged 5 commits into
Azure:mainfrom
alexeldeib:ace/mig
Oct 2, 2021
Merged

Xing Zhou (zhoxing-ms) merged 5 commits into
Azure:mainfrom
alexeldeib:ace/mig

Conversation

@alexeldeib

Copy link
Copy Markdown
Contributor

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
    • this fails but not on anything related to my diff.
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan

Copy link
Copy Markdown
Collaborator

aks

@FumingZhang

Copy link
Copy Markdown
Member

It seems that the live test pipeline failed on a removed test case test_aks_nodepool_add_with_workload_runtime, but test_aks_nodepool_add_with_gpu_instance_profile is not tested? Could you please queue another test? If the newly added option needs feature registration, you may exclude this test case in ext_matrix_default.json.

@alexeldeib

Copy link
Copy Markdown
Contributor Author

ah sorry, I mixed up the tests with this and #3896

@alexeldeib

Copy link
Copy Markdown
Contributor Author

I'll exclude the live test due to feature registration, unfortunately same issue applies to #3896

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May consider using a variable to wrap these options?

@alexeldeib

Copy link
Copy Markdown
Contributor Author

FumingZhang anything we're waiting on here for merge?

@zhoxing-ms

Xing Zhou (zhoxing-ms) commented Sep 24, 2021 •

Copy link
Copy Markdown
Contributor

Ace Eldeib (@alexeldeib) Please write those changes into the HISTORY.rst

By the way, do you need to release a new version for these changes? If so, please also update the setup.py

@zhoxing-ms

Copy link
Copy Markdown
Contributor

Ace Eldeib (@alexeldeib) Could you please address those conflicts?

@alexeldeib

Copy link
Copy Markdown
Contributor Author

rebased 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants