Repository navigation
AKS: support private cluster public fqdn feature with new api 2021-05-01 - #3465
Merged
Xing Zhou (zhoxing-ms) merged 6 commits intoJun 8, 2021
Merged
Conversation
Li Ma (levimm)
requested review from
Liming Liu (andyliuliming),
Ganesha (gtracer) and
Qingqing (zqingqing1)
as code owners
June 4, 2021 08:03
Pengfei Ni (feiskyer)
approved these changes
Jun 4, 2021
Collaborator
|
AKS |
Yong Zhang (yonzhan)
requested review from
Zunli Hu (Juliehzl) and
Xing Zhou (zhoxing-ms)
June 5, 2021 03:46
Comment on lines
391
to
+392
| def list_cluster_admin_credentials( | ||
| self, resource_group_name, resource_name, custom_headers=None, raw=False, **operation_config): | ||
| self, resource_group_name, resource_name, server_fqdn=None, custom_headers=None, raw=False, **operation_config): |
Contributor
There was a problem hiding this comment.
Why not upgrade the entire vendor SDK, but modify only one file?
Contributor
Author
There was a problem hiding this comment.
I upgrade the entire sdk in this commit: #3453
And then we have a hotfix for swagger to add this query param. That's why I update this one sdk file again based on latest swagger.
|
|
||
| 0.5.16 | ||
| +++++ | ||
| * Vendor sdk using latest swagger with optional query param added |
Contributor
There was a problem hiding this comment.
Suggested change
| * Vendor sdk using latest swagger with optional query param added | |
| * Vendor SDK using latest swagger with optional query parameter added |
Xing Zhou (zhoxing-ms)
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.