Skip to content

[Scheduled-Query] update api version - #3399

Merged
kai ru (kairu-ms) merged 9 commits into
Azure:masterfrom
kairu-ms:scheduled-query-update-api-version
May 31, 2021
Merged

[Scheduled-Query] update api version#3399
kai ru (kairu-ms) merged 9 commits into
Azure:masterfrom
kairu-ms:scheduled-query-update-api-version

Conversation

@kairu-ms

@kairu-ms kai ru (kairu-ms) commented May 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

closed Azure/azure-cli#17891

  • Add --skip-query-validation parameter
  • Add --check-ws-alerts-storage parameter
  • [Breaking Change] the default value of --mute-actions-duration is removed because alert auto mitigate is supported

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan

Yong Zhang (yonzhan) commented May 19, 2021

Copy link
Copy Markdown
Collaborator

Scheduled-Query

@yonzhan Yong Zhang (yonzhan) added this to the S187 milestone May 19, 2021
@yanivlavi

Yaniv Lavi (yanivlavi) commented May 19, 2021

Copy link
Copy Markdown
Contributor

kai ru (@kairu-ms)
Flag '--mute-actions-duration' is not removed.
It is only supported when stateful is disabled. Stateful should be a flag control setting with default being enabled.

Please pass this PR with us for sign-off before you merge.

@yanivlavi

Yaniv Lavi (yanivlavi) commented May 19, 2021

Copy link
Copy Markdown
Contributor

Please make sure you do not diverge from metric alerts as they also have 'auto-mitigate' option.
Keep in mind we want to be aligned with them.

@kairu-ms

kai ru (kairu-ms) commented May 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

kai ru (@kairu-ms)
Flag '--mute-actions-duration' is not removed.
It is only supported when stateful is disabled. Stateful should be a flag control setting with default being enabled.

Please pass this PR with us for sign-off before you merge.

Thanks for your feedback, I have two question:

  1. What do you mean by stateful? Can user enable or disable stateful by cli?
  2. I don't remove the --mute-actions-duration flag. I've changed the default value of it to None. Do you want to remove it?

@yanivlavi

Yaniv Lavi (yanivlavi) commented May 20, 2021

Copy link
Copy Markdown
Contributor

Thanks for your feedback, I have two question:

  1. What do you mean by stateful? Can user enable or disable stateful by cli?

Yes, it is controlled by the 'autoMitigate' flag in the API. Would like to have that controllable in the CLI.

  1. I don't remove the --mute-actions-duration flag. I've changed the default value of it to None. Do you want to remove it?

No, when 'autoMitigate' is false you can still set mute-actions-duration.
The defaults should be 'autoMitigate' true, mute-actions-duration is fine to be None as default.

@yanivlavi

Yaniv Lavi (yanivlavi) commented May 20, 2021

Copy link
Copy Markdown
Contributor

What was the default for muting before?

@kairu-ms

kai ru (kairu-ms) commented May 20, 2021

Copy link
Copy Markdown
Contributor Author

What was the default for muting before?

The default value is 30 minutes

@kairu-ms

kai ru (kairu-ms) commented May 20, 2021

Copy link
Copy Markdown
Contributor Author

Thanks for your feedback, I have two question:

  1. What do you mean by stateful? Can user enable or disable stateful by cli?

Yes, it is controlled by the 'autoMitigate' flag in the API. Would like to have that controllable in the CLI.

  1. I don't remove the --mute-actions-duration flag. I've changed the default value of it to None. Do you want to remove it?

No, when 'autoMitigate' is false you can still set mute-actions-duration.
The defaults should be 'autoMitigate' true, mute-actions-duration is fine to be None as default.

I see. I will add that control in CLI.

@yonzhan Yong Zhang (yonzhan) modified the milestones: S187, S188 May 21, 2021
jsntcy
Yu Chen (jsntcy) reviewed May 25, 2021
View reviewed changes
Comment thread src/scheduled-query/azext_scheduled_query/_params.py Outdated
jsntcy
Yu Chen (jsntcy) reviewed May 25, 2021
View reviewed changes
Comment thread src/scheduled-query/azext_scheduled_query/_params.py Outdated
jsntcy
Yu Chen (jsntcy) reviewed May 25, 2021
View reviewed changes
Comment thread src/scheduled-query/azext_scheduled_query/_params.py Outdated

@jsntcy Yu Chen (jsntcy) May 25, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add default value in help message

jsntcy
Yu Chen (jsntcy) approved these changes May 25, 2021
View reviewed changes

@jsntcy Yu Chen (jsntcy) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kairu-ms

kai ru (kairu-ms) commented May 25, 2021

Copy link
Copy Markdown
Contributor Author

Hi, Yaniv Lavi (@yanivlavi) does this PR ready to release?

@kairu-ms
kai ru (kairu-ms) force-pushed the scheduled-query-update-api-version branch from 587deac to 6e034b7 Compare May 31, 2021 03:27
@kairu-ms
kai ru (kairu-ms) force-pushed the scheduled-query-update-api-version branch from 6e034b7 to eb2ac0d Compare May 31, 2021 07:26
@kairu-ms
kai ru (kairu-ms) merged commit 5ed250a into Azure:master May 31, 2021
kai ru (kairu-ms) added a commit to kairu-ms/azure-cli-extensions that referenced this pull request Jun 21, 2021
@kairu-ms
Revert "[Scheduled-Query] update api version (Azure#3399)"
75217ef 
This reverts commit 5ed250a.
kai ru (kairu-ms) added a commit that referenced this pull request Jun 22, 2021
@kairu-ms
Revert "[Scheduled-Query] update api version (#3399)" (#3526)
b82ed96 
* Revert "[Scheduled-Query] update api version (#3399)"

This reverts commit 5ed250a.

* update extension version

* update recording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsntcy Yu Chen (jsntcy) jsntcy approved these changes
@00Kai0 Kerwin(Kaihui) Sun (00Kai0) Awaiting requested review from 00Kai0
@yanivlavi Yaniv Lavi (yanivlavi) Awaiting requested review from yanivlavi

Assignees

@kairu-ms kai ru (kairu-ms)

Labels

None yet

Projects

None yet

Milestone

S188

Development

Successfully merging this pull request may close these issues.

Scheduled query rules CMK check flag, stateful alerts and 1-minute frequency

4 participants

@kairu-ms @yonzhan @yanivlavi @jsntcy