Repository navigation
Update RDBMS SDKs for PostgreSQL and MySQL. - #104
Merged
Merged
Conversation
Rohit Joy (rohit-joy)
requested a review
from Derek Bekoe (derekbekoe)
as a code owner
March 19, 2018 23:46
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
Derek Bekoe (derekbekoe)
approved these changes
Mar 19, 2018
Member
|
Looks like the tests would need to be recorded as CI failed. |
Contributor
Author
|
Derek Bekoe (@derekbekoe), I was running them. :) Recordings are updated now. |
Contributor
Author
|
Derek Bekoe (@derekbekoe), please merge. |
Xing Zhou (zhoxing-ms)
pushed a commit
that referenced
this pull request
Mar 30, 2022
) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model * Stage Public Version of k8s-extension 0.2.0 for official release (#15) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model Co-authored-by: action@github.com <Action - Fork Sync> * Remove custom pipelines file * Update extension description, remove private const * Update pipeline file * Disable refs docs * Update to include better create warning logs and remove update context (#20) * Update to include better create warning logs and remove update context * Remove help text for update * Fix spelling error * Update message * Fix k8s-extension conflict with private version * Fix style errors * Fix filename * add customization for microsoft.azureml.kubernetes (#23) * add customization for microsoft.azureml.kubernetes * Update release history Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Add E2E Testing from Separate branch into internal code (#26) * Add internal e2e testing * Change to testing folder * Inference CLI validation for Scoring FE (#24) * cli validation starter * added the call to the fe validation function * nodeport validation not required * test fix Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * legal warning added (#27) * Remove deprecated method logger.warn * Update k8s-custom-pipelines.yml for Azure Pipelines * Update k8s-custom-pipelines.yml for Azure Pipelines * Add Azure Defender to E2E testing (#28) * Add azure defender testing to e2e * Remove the debug flag * Add configuration testing * Fix pipeline failures * Make test script more intuitive * Remove parameter from testing * Fix wrong location for k8s config whl * Fix pip upgrade issue * Fix pip install upgrade issue * Fix pip install issue * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Provider registration case insensitive * do not validate against scoring fe if inference is not enabled. (#33) * do not validate against scoring fe if inference is not enabled. * add inference enabled scenario * refine * increase sleeping time * fix Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add OSM as Public Preview Extension (#34) * Add OSM as public preview extension * Add osm testing * Add release train to tests * Fix failing osm test * Upgrade pip in integration testing * Remove ununsed import * Fix release train check in update * Parallelize E2E Testing (#36) * Add OSM as public preview extension * Add osm testing * Update test logic to parallelize * Fix test success checking * Parallelize extension testing * Better error checking logic * Fix azureml deletion * Fix private build (#40) * change amlk8s to amlarc (#42) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Servicebus client model changes (#44) * Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates * Read SSL cert and key from files (#38) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Upgrade release version * Liakaz/inference read ssl from file (#47) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments * fixed decode error * renamed the experimental param Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix style issues (#51) * Fixed scoring fe related extension param names (#49) * fixed scoring fe related extension params * bug fix and style fixes * variable rename * fixed the error type * set cluster to prod by default * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#53) removed release-train logic * Add Custom Delete Logic for Partners (#54) * Add custom delete logic * Fix failing unit tests * Add warning message when deleting amlarc extension (#55) * add warning message * fix indentation * Update release version * Remove Pyhelm from OSM customization (#58) * Fix OSM pyhelm bug * Debug bootstrap error * Update release message * Remove pyhelm dependency * Update tests to only check extensionconfig creation (#61) * Update tests to only check extensionconfig creation * Single set of CRUD for AzureML * Debug logs for connectedk8s * Increase open service mesh version number * Update k8s-extension Models to Track2 (#64) * Update k8s-extension models to track2 * Add debug for failed cleanup * Increase version number * Exit 0 on failed cleanup * Fix identity in wrong place in model (#66) * Readd osm-arc distro validation (#62) * Add distro validation for osm-arc removed release-train logic * Readd osm_arc distro validation * Fix style * Rm space * Edit test * Fixed tests and error logic * Remove dependency * Add delete method Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Don't Send Identity Headers If In DF (#67) * Don't send identity for clusters in dogfood * Add location to model for identity * Add identity validation to testing * Use default extension with identity instead of Cassandra specific (#69) * Remove the identity check for now * Add -t for clusterType parameter (#71) * Adding a flag for AKS to AMLARC migration and set up corresponding FE… (#65) * Adding a flag for AKS to AMLARC migration and set up corresponding FE helm values * Remove one extra line * Adding Scoring FE IS_AKS_MIGRATION check logic for helm values Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * remove version requirement and auto upgrade minor version check (#72) * Custom User Confirmation for Partners (#70) * Custom user confirmation * Check for disable confirm prompty for confirmation * Add yes to delete command * Code cleanup and style fixes (#73) * Enabled identity by default (#74) * Increase version * Fix df check and add unit test (#77) * Bump extension version * Pin helm version * Extensions GA changes into Public Branch (#79) * Add openservicemesh back * OpenServiceMesh import * Update osm with new extension model * Add back private file * Add Azure ML to list of private extensions (#16) * Update k8s-custom-pipelines.yml * Add Microsoft.PolicyInsights extension (#17) * Add Policy extension * Update comment * Update args * Fix linting errors Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add HISTORY_private file for private preview * Change versioning scheme * Update the code for supporting both extensions at once * Fix style issue * Remove old consts file * change the resource tag from managed_by:amlk8s to created_by:amlk8s-e… (#22) * change the resource tag from managed_by:amlk8s to created_by:amlk8s-extension * remove the lock when creating resources * fix lint * update version and HISTORY_private.rst * change error message Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update the beta version with upstream * Update the private history file * Add upgrade pip to pipeline * Move pip install within virtualenv * Merge in k8s-extension/public (0.3.1) (#32) * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Update private release Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Release Version 0.4.0-b1 (#37) * Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency * K8s extension/private 0.4.0b2 (#41) * Fix private build (#40) * Update version * Upgrade to v0.5.2 * Fix policy bug * Increase private version * Update consts_private.py * Increase private version * Increase version with public * Add flux to private version * Update models for 2021-05-01-preview * Add async models to version * Add no wait to delete and create * support managed cluster * Bump version * Pin helm version * Add cmd to delete call * Add force deletion * add dapr extension (#78) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Fix failing integration tests * Adding the GA changes for private branch * Fix confirm prompt * Fix update E2E tests Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> * Fix configuration settings in update * Only provide confirmation when specifying settings * Fix style issues * Cassandra tests with update (#81) * Add Microsoft.PolicyInsights extension for public preview (#83) * Add Azure Policy * Remove custom configuration and update tests * Yuyu3/fix upgrade public (#85) * populate configuration protected settings for azureml bump version && add log fetch connection string only if configuration protected settings are set update ssl key * bump the version * reverse changes on version and HISTORY.rst * inferenceLoadBalancerHA Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Remove Parallel Powershell Jobs (#82) * Unparallelize tests * Moved location of pipeline file * Remove the parallel invoke expression calls * Add templates to testing * Remove policy update test from extension E2E (#88) * feIsNodePort, feIsInternalLoadBalancer (#87) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix history file * Add one more prompt for amlarc extension update (#94) * Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> * Update Identity Creation for Appliance to Latest Version (#95) * Update appliance API to latest version for identity * Create a utils file with get parent_api_version * Fix style errors * Bump version * Remove additional entry from history * Do not create identity with appliances (#97) * Bump version * support sslSecret (#99) * support sslSecret * fix * fix error message Co-authored-by: Jun Min <mijun@microsoft.com> * Bump version to 1.0.4 * Increase OSM verison to valid version (#104) * remove inference private review warning message (#102) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Update unit testing from osm to dapr (#106) * osm-ext: enable system identities (#105) * remove inference private review warning message (#109) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Build Extension in Template (#110) * Build extension using a template * Update build template in run test * Fix private build issues (#112) * Upgrade vendored_sdks to 2022-03-01 (#113) * Upgrade vendored_sdks to 2022-03-01 * Update recordings file * Bump version and changelog * Remove unneeded files Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Lia Kazakova <58274127+liakaz@users.noreply.github.com> Co-authored-by: Niranjan Shankar <nshankar@microsoft.com> Co-authored-by: jingyizhu99 <83610845+jingyizhu99@users.noreply.github.com> Co-authored-by: Harry Yang <huaimingyang@hotmail.com> Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Thomas Stringer <thomas@trstringer.com> Co-authored-by: NarayanThiru <nanthi@microsoft.com> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> Co-authored-by: youhuatuyh <87928654+youhuatuyh@users.noreply.github.com> Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> Co-authored-by: Jun <mjaow0128@gmail.com> Co-authored-by: Jun Min <mijun@microsoft.com> Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Xing Zhou (zhoxing-ms)
pushed a commit
that referenced
this pull request
Jul 29, 2022
* Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model * Stage Public Version of k8s-extension 0.2.0 for official release (#15) * Create pull.yml * Update pull.yml * Update azure-pipelines.yml * Initial commit of k8s-extension * Update pipelines file * Update CODEOWNERS * Update private preview pipelines * Remove open service mesh from public release * Update pipeline files * Update public extension pipeline * Change condition variable * Add version to public preview/private preview * Update pipelines * Add different testing based on private branch * Add annotations to extension model * Update k8s-custom-pipelines.yml * Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13) * Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import * remove py2 bdist support * Add custom table formatting * Remove unnecessary files * Fix style issues * Fix branch based on comments * Update identity piece manually * Don't handle defaults at the CLI level * Remove defaults from CLI client * Check null target namespace with namespace scope * Update style * Add cassandra operator and location to model Co-authored-by: action@github.com <Action - Fork Sync> * Remove custom pipelines file * Update extension description, remove private const * Update pipeline file * Disable refs docs * Update to include better create warning logs and remove update context (#20) * Update to include better create warning logs and remove update context * Remove help text for update * Fix spelling error * Update message * Fix k8s-extension conflict with private version * Fix style errors * Fix filename * add customization for microsoft.azureml.kubernetes (#23) * add customization for microsoft.azureml.kubernetes * Update release history Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Add E2E Testing from Separate branch into internal code (#26) * Add internal e2e testing * Change to testing folder * Inference CLI validation for Scoring FE (#24) * cli validation starter * added the call to the fe validation function * nodeport validation not required * test fix Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * legal warning added (#27) * Remove deprecated method logger.warn * Update k8s-custom-pipelines.yml for Azure Pipelines * Update k8s-custom-pipelines.yml for Azure Pipelines * Add Azure Defender to E2E testing (#28) * Add azure defender testing to e2e * Remove the debug flag * Add configuration testing * Fix pipeline failures * Make test script more intuitive * Remove parameter from testing * Fix wrong location for k8s config whl * Fix pip upgrade issue * Fix pip install upgrade issue * Fix pip install issue * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Provider registration case insensitive * do not validate against scoring fe if inference is not enabled. (#33) * do not validate against scoring fe if inference is not enabled. * add inference enabled scenario * refine * increase sleeping time * fix Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add OSM as Public Preview Extension (#34) * Add OSM as public preview extension * Add osm testing * Add release train to tests * Fix failing osm test * Upgrade pip in integration testing * Remove ununsed import * Fix release train check in update * Parallelize E2E Testing (#36) * Add OSM as public preview extension * Add osm testing * Update test logic to parallelize * Fix test success checking * Parallelize extension testing * Better error checking logic * Fix azureml deletion * Fix private build (#40) * change amlk8s to amlarc (#42) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Servicebus client model changes (#44) * Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates * Read SSL cert and key from files (#38) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Upgrade release version * Liakaz/inference read ssl from file (#47) * first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments * fixed decode error * renamed the experimental param Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix style issues (#51) * Fixed scoring fe related extension param names (#49) * fixed scoring fe related extension params * bug fix and style fixes * variable rename * fixed the error type * set cluster to prod by default * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#50) * Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add distro validation for osm-arc (#53) removed release-train logic * Add Custom Delete Logic for Partners (#54) * Add custom delete logic * Fix failing unit tests * Add warning message when deleting amlarc extension (#55) * add warning message * fix indentation * Update release version * Remove Pyhelm from OSM customization (#58) * Fix OSM pyhelm bug * Debug bootstrap error * Update release message * Remove pyhelm dependency * Update tests to only check extensionconfig creation (#61) * Update tests to only check extensionconfig creation * Single set of CRUD for AzureML * Debug logs for connectedk8s * Increase open service mesh version number * Update k8s-extension Models to Track2 (#64) * Update k8s-extension models to track2 * Add debug for failed cleanup * Increase version number * Exit 0 on failed cleanup * Fix identity in wrong place in model (#66) * Readd osm-arc distro validation (#62) * Add distro validation for osm-arc removed release-train logic * Readd osm_arc distro validation * Fix style * Rm space * Edit test * Fixed tests and error logic * Remove dependency * Add delete method Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Don't Send Identity Headers If In DF (#67) * Don't send identity for clusters in dogfood * Add location to model for identity * Add identity validation to testing * Use default extension with identity instead of Cassandra specific (#69) * Remove the identity check for now * Add -t for clusterType parameter (#71) * Adding a flag for AKS to AMLARC migration and set up corresponding FE… (#65) * Adding a flag for AKS to AMLARC migration and set up corresponding FE helm values * Remove one extra line * Adding Scoring FE IS_AKS_MIGRATION check logic for helm values Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * remove version requirement and auto upgrade minor version check (#72) * Custom User Confirmation for Partners (#70) * Custom user confirmation * Check for disable confirm prompty for confirmation * Add yes to delete command * Code cleanup and style fixes (#73) * Enabled identity by default (#74) * Increase version * Fix df check and add unit test (#77) * Bump extension version * Pin helm version * Extensions GA changes into Public Branch (#79) * Add openservicemesh back * OpenServiceMesh import * Update osm with new extension model * Add back private file * Add Azure ML to list of private extensions (#16) * Update k8s-custom-pipelines.yml * Add Microsoft.PolicyInsights extension (#17) * Add Policy extension * Update comment * Update args * Fix linting errors Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Add HISTORY_private file for private preview * Change versioning scheme * Update the code for supporting both extensions at once * Fix style issue * Remove old consts file * change the resource tag from managed_by:amlk8s to created_by:amlk8s-e… (#22) * change the resource tag from managed_by:amlk8s to created_by:amlk8s-extension * remove the lock when creating resources * fix lint * update version and HISTORY_private.rst * change error message Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update the beta version with upstream * Update the private history file * Add upgrade pip to pipeline * Move pip install within virtualenv * Merge in k8s-extension/public (0.3.1) (#32) * delete resurce in testcase (#29) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Check Provider is Registered with Subscription Before Making Requests (#18) * Add check for KubernetesConfiguration * Disable pylint and rename * Update provider registration link * Update version * Remove extra blank line * Fix bug in import * only validate scoring fe when inference is enabled (#31) * only validate scoring fe when inference is enabled * Fix versioning Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> * Update private release Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Release Version 0.4.0-b1 (#37) * Merge k8s-extension/public into k8s-extension/private * Update the version * Fix testing concurrency * K8s extension/private 0.4.0b2 (#41) * Fix private build (#40) * Update version * Upgrade to v0.5.2 * Fix policy bug * Increase private version * Update consts_private.py * Increase private version * Increase version with public * Add flux to private version * Update models for 2021-05-01-preview * Add async models to version * Add no wait to delete and create * support managed cluster * Bump version * Pin helm version * Add cmd to delete call * Add force deletion * add dapr extension (#78) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * Fix failing integration tests * Adding the GA changes for private branch * Fix confirm prompt * Fix update E2E tests Co-authored-by: jonathan-innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> * Fix configuration settings in update * Only provide confirmation when specifying settings * Fix style issues * Cassandra tests with update (#81) * Add Microsoft.PolicyInsights extension for public preview (#83) * Add Azure Policy * Remove custom configuration and update tests * Yuyu3/fix upgrade public (#85) * populate configuration protected settings for azureml bump version && add log fetch connection string only if configuration protected settings are set update ssl key * bump the version * reverse changes on version and HISTORY.rst * inferenceLoadBalancerHA Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Remove Parallel Powershell Jobs (#82) * Unparallelize tests * Moved location of pipeline file * Remove the parallel invoke expression calls * Add templates to testing * Remove policy update test from extension E2E (#88) * feIsNodePort, feIsInternalLoadBalancer (#87) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix history file * Add one more prompt for amlarc extension update (#94) * Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> * Update Identity Creation for Appliance to Latest Version (#95) * Update appliance API to latest version for identity * Create a utils file with get parent_api_version * Fix style errors * Bump version * Remove additional entry from history * Do not create identity with appliances (#97) * Bump version * support sslSecret (#99) * support sslSecret * fix * fix error message Co-authored-by: Jun Min <mijun@microsoft.com> * Bump version to 1.0.4 * Increase OSM verison to valid version (#104) * remove inference private review warning message (#102) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Update unit testing from osm to dapr (#106) * osm-ext: enable system identities (#105) * remove inference private review warning message (#109) Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Build Extension in Template (#110) * Build extension using a template * Update build template in run test * Fix private build issues (#112) * Upgrade vendored_sdks to 2022-03-01 (#113) * Upgrade vendored_sdks to 2022-03-01 * Update recordings file * Bump version and changelog * Update AzureMLKubernetes install parameters on inferenceRouterServiceType and internalLoadBalancerProvider (#114) * Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue * merge from AzureArcForKubernetes/azure-cli-extensions * Update AzureMLKubernetes install parameters on inferenceRouterServiceType and internalLoadBalancerProvider * update error message * update error message * fix pipeline failures * fix test failure Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Change extension validation logic osm-arc (#116) * added default identity support for microsoft.azurebackup.backupagent (#115) * Change extension validation logic osm-arc Signed-off-by: nshankar13 <nshankar@microsoft.com> Co-authored-by: sangitaray2021 <82883570+sangitaray2021@users.noreply.github.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * [k8s-extension] Add Managed Identity Auth support for ContainerInsights Extension (#118) * container insights aad auth support * container insights aad auth support * container insights aad auth support * handle useAADAuth setting * handle useAADAuth setting * delete dcr-a if its exists incase of MSI auth * fix formatting * fix formatting * fix formatting * fix formatting Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * fix install issue on aks (#119) * fix install issue on aks * Removing checking distribution Co-authored-by: youhuatu <youhuatu@outlook.com> * [k8s-extension] Bring back containerInsights solution addition in msi mode (#120) * bring back containerinsights solution in dcr mode * bring back containerinsights solution in dcr mode * Bump release version * Remove backup agent from mapping * Fix history file * clusterip (#121) * clusterip * fix pr test Co-authored-by: Jun Min <mijun@microsoft.com> * No default values for the patch scenario with extension (#122) * Bump version to 1.2.1 * Rename inferenceLoadBalancerHA (#123) * Rename inferenceLoadBalancerHA Rename inferenceLoadBalancerHA to inferenceRouterHA and unify related logic * Update AzureMLKubernetes.py * Remove unused comments to trigger pipeline * Update AzureMLKubernetes.py * Yuyu3/remove relay (#124) * remove relay * disable service bus by default, disable relay if target cluster is managed clusters. * move nginx ingress logic * remove service bus in tests * update HISTORY * If no default values provided for update, assign an empty dict. * set original_extension_config_settings to empty dict if it is None. * bump version to 1.2.2 Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Update test documentation for partners (#132) * remove warning message (#129) Co-authored-by: Yue Yu <yuyu3@microsoft.com> * Use cluster scale to control clusterPurpose and inferenceRouterHA (#130) * Use cluster scale to control clusterPurpose and inferenceRouterHA * Update AzureMLKubernetes.py To solve transient gate error * Update AzureMLKubernetes.py * Update AzureMLKubernetes.py * Update AzureMLKubernetes.py Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> * Fix warning message returned on PATCH (#133) * Do not invoke 'create_or_update' if resource is already exists. (#135) * init * update HISTORY * do not populate clusterPurpose if infrenceRouterHA is not set. * use correct exception type. * use correct exception type. * fix lint * use correct exception type. Co-authored-by: Yue Yu <yuyu3@microsoft.com> * [k8s-extension] ContainerInsights Extension Managed Identity Auth Onboarding updates (#137) * bring back containerinsights solution in dcr mode * bring back containerinsights solution in dcr mode * update to stream group and DCR API version * Only test k8s-extension * [k8s-extension] ContainerInsights Extension Managed Identity Auth Onboarding related bug fixes (#141) * fix bugs * fix indent issues * remove get workspace key for msi auth * fix pr feedback * Fix osm-arc installation non-connected clusters Signed-off-by: nshankar13 <nshankar@microsoft.com> * k8s-extension azuredefender namespace to mdc (#152) Co-authored-by: Bsingh16 <33008256+bavneetsingh16@users.noreply.github.com> * change codeowners for k8s extension & configuration (#150) * change codeowners for k8s extension & configuration * change code owners Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> * bump k8s-extension version to 1.2.5 * delete testing files Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com> Co-authored-by: action@github.com <Action - Fork Sync> Co-authored-by: yuyue9284 <15863499+yuyue9284@users.noreply.github.com> Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Lia Kazakova <58274127+liakaz@users.noreply.github.com> Co-authored-by: Niranjan Shankar <nshankar@microsoft.com> Co-authored-by: jingyizhu99 <83610845+jingyizhu99@users.noreply.github.com> Co-authored-by: Harry Yang <huaimingyang@hotmail.com> Co-authored-by: Harry Yang <huayang@microsoft.com> Co-authored-by: Thomas Stringer <thomas@trstringer.com> Co-authored-by: NarayanThiru <nanthi@microsoft.com> Co-authored-by: nreisch <noahreisch4@gmail.com> Co-authored-by: anagg929 <59664801+anagg929@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: nanthi <nanthi@NANTHI01> Co-authored-by: youhuatuyh <87928654+youhuatuyh@users.noreply.github.com> Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com> Co-authored-by: Jun <mjaow0128@gmail.com> Co-authored-by: Jun Min <mijun@microsoft.com> Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com> Co-authored-by: sangitaray2021 <82883570+sangitaray2021@users.noreply.github.com> Co-authored-by: Ganga Mahesh Siddem <gangams@microsoft.com> Co-authored-by: WangDian <wangdian82@gmail.com> Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Niv Ben Shabat <70891304+nishabat@users.noreply.github.com>
NoriZC
pushed a commit
that referenced
this pull request
Oct 14, 2026
* Update onboarding flow to inject kubernetes secret without using helm (#47) * Update onboarding flow to inject kubernetes secret without using helm values * add whl file for testing * update whl file after rebase --------- Co-authored-by: John McCormick <mccormickjo@microsoft.com> * Report ARM ID in command and fault telemetry (#59) * add wrapper for telemetry that adds ArmId to payload * add standardized error data type and methods * update other telemetry call sites for errors to use centralized error wrapper * update helm get values failure to use new error reporting, and add documentation * update test and pass ruff checks * fix argument error from rebase --------- Co-authored-by: John McCormick <mccormickjo@microsoft.com> * Update client proxy version (#72) * Fix linting issues, and Update CI checks (#76) * add a git workflow to update sync/upstream-main and add release docs * fixing azdev pipelines and cli testing passthrough * update azdev pipelines, and use federated credential for ado pipeline * update CLI testing * update cli testing to use github auth * chore: retrigger ADO PR validation * fix formatting issues for CI, and remove cli wide test that fails on a missing ref * improve efficiency and fix version calculation * ruff formatting --------- Co-authored-by: John McCormick <mccormickjo@microsoft.com> * Fix/connectedk8s prediagnostic job completion (#80) * fix(connectedk8s): reconcile diagnostic job completion * test(connectedk8s): cover diagnostic job outcomes * fix(connectedk8s): extend diagnostic job timeout * refactor(connectedk8s): rely on extended diagnostic timeout * chore(connectedk8s): remove test attribution comment * feat(connectedk8s): explain incomplete diagnostic jobs * fix(connectedk8s): remove unused noqa directives * chore(connectedk8s): retrigger validation pipeline * fix(connectedk8s): resolve ruff style failures * fix(connectedk8s): suppress delayed import lint * fix(connectedk8s): suppress diagnostic helper return lint * Adding AZK8S0600-0699 pre-onboarding diagnostic error codes (#81) * feat(connectedk8s): add AZK8S0600-0699 pre-onboarding diagnostic error codes Add structured error code infrastructure and wire the 0600-0699 range (pre-onboarding diagnostics) so users see actionable codes in errors and warnings instead of raw messages. New file: - _error_codes.py: ERROR_CATALOG dict (full range 0001-0805) plus raise_with_code() and warn_with_code() helpers that prepend the code to the message and emit telemetry in a single call. _constants.py: - Added AZK8S0600-AZK8S0607 error code constants. _precheckutils.py: - Import raise_with_code, warn_with_code from _error_codes. - AZK8S0604: job not scheduled -> warn_with_code (non-fatal). - AZK8S0606: log save failed (OSError + ValueError/TypeError) -> warn_with_code (non-fatal). - AZK8S0605: job not complete -> warn_with_code (non-fatal). - AZK8S0601: outer except in executing_cluster_diagnostic_checks_job -> raise_with_code(CLIInternalError). - AZK8S0607: helm install of diagnostic checks chart failed -> raise_with_code(CLIInternalError). custom.py: - Import raise_with_code from _error_codes. - AZK8S0600: outer except wrapping fetch_diagnostic_checks_results -> raise_with_code(CLIInternalError). - AZK8S0603: Diagnostic_Check_Incomplete -> raise_with_code(ValidationError). - AZK8S0602: Diagnostic_Check_Failed -> raise_with_code(ValidationError). * fix(connectedk8s): preserve prediagnostic error classifications * docs(connectedk8s): clarify error classification * Update csp version (#85) * Implement Helm Error Code Standardization (AZK8S05XX) (#73) * add helm errors * update precheck utils to raise the helm errors for helm client failures * introduce generic Helm client error and fix cmd typing and error supression * update tests * remove whl * fixes * add arm id to prechecks + troubleshooting telemetry + remove helm url helm url could contain credentials so removing from telemetry * fix param issue in delete_arc_agents * ruff format and simplify if statment * fix unittest * update test inputs * fixes * update stub to use kwargs as well * update helm checks and sanitize telemetry payload * move logging, and raise in place --------- Co-authored-by: John McCormick <mccormickjo@microsoft.com> * Proxy Bypass for Arc Service endpoints and Container Insights. (#86) * Add Container Insights proxy bypass constants and utils * Add --proxy-bypass and --clear-proxy-bypass parameters * Apply Container Insights proxy bypass during connect * Apply Container Insights proxy bypass only when its keyword is specified * Remove Arc keyword from --proxy-skip-range * Add Arc keyword to proxy bypass constants * Rename --proxy-bypass to --add-proxy-bypass and validate keywords * Add proxy bypass parameters to update * Append Arc endpoints to noProxy during connect * Preserve Arc proxy bypass across update * Remove Arc endpoints from noProxy during update * Add Container Insights proxy bypass into update * Update comment for Container Insights * Set Container Insights proxy bypass to false on clear * Remove Container Insights proxy bypass on delete * Clear stale Container Insights proxy bypass on re-onboard * Allow clearing the Arc proxy bypass with a new skip range * Add proxy bypass keywords in help * Add tests for the proxy bypass keywords * To address proxy bypass naming, messages and tests * Add telemetry to Container Insights ConfigMap failures. * Fix missing cmd argument in helm values call and apply ruff format --------- Co-authored-by: Sai Tareesh Reddy Eppeti <seppeti@microsoft.com> * Standardize custom locations errors (AZK8S0700–AZK8S0702) (#90) * feat(connectedk8s): standardize custom locations errors * test(connectedk8s): verify custom locations telemetry * Standardize network and connectivity errors (AZK8S0300–AZK8S0309) (#87) * feat(connectedk8s): standardize network connectivity errors * fix(connectedk8s): suppress outbound check local count lint * docs(connectedk8s): clarify network error handling * fix(connectedk8s): consolidate network diagnostic telemetry * Add AGC Endpoint Configuration for Agent installation and Client-Side Proxy Operation (#68) Add AGC Endpoint Configuration for Agent installation and Client-Side Proxy Operation Added the AGC Helm override for MsiAdapterArtifactImageRegistry Passing CloudConfig for Client-Side Proxy Scenario in AGC since default cloud name isn't supported. * Implement kubectl/ Cluster Access Error Standardization (AZK8S02XX) (#74) * Standardize network and connectivity errors (AZK8S0300–AZK8S0309) (#87) * feat(connectedk8s): standardize network connectivity errors * fix(connectedk8s): suppress outbound check local count lint * docs(connectedk8s): clarify network error handling * fix(connectedk8s): consolidate network diagnostic telemetry * Add AGC Endpoint Configuration for Agent installation and Client-Side Proxy Operation (#68) Add AGC Endpoint Configuration for Agent installation and Client-Side Proxy Operation Added the AGC Helm override for MsiAdapterArtifactImageRegistry Passing CloudConfig for Client-Side Proxy Scenario in AGC since default cloud name isn't supported. * add error type for failed to inject private key * initial error implementation * standardize cmd type and add logger.warning to connectedk8s warning telemetry function * ruff format * fixes to telemetry * update az error classes for kubectl errors * restore no raising error to namespace cleanup on delete * update errors to pass in the underlying exception type * ruff format * test(connectedk8s): remove misplaced proxy error tests Keep the proxy error coverage on the proxy-errors branch while correcting the unrelated Kubernetes exception expectations and namespace cleanup clock mock. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * ensure only one telemetry event and no duplicates * remove duplicate faults * update telemetry to strip apostrophes for AZ telemetry * ruff * linting fixes * fix(connectedk8s): remove duplicate command context arguments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix duplicate telemetry * ruff format * fix indentation * chore: retrigger mergability+pr checks --------- Co-authored-by: Ashlee Nanze <ashleenanzework@gmail.com> Co-authored-by: junw98 <junweihe@microsoft.com> Co-authored-by: John McCormick <mccormickjo@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * ARM operation Error Handling/Telemetry (AZK8S04XX) (#82) * add in ARM operation error handling/reporting * ruff format * fix(connectedk8s): sanitize telemetry payloads Apply the shared redaction helpers to standardized errors and extension event values while preserving ARM resource IDs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(connectedk8s): preserve telemetry exception types Keep sanitized exception messages without collapsing fault classification, and cover command and ARM boundaries against duplicate fault emission. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(connectedk8s): type sanitized exception Bind the dynamically created telemetry exception to BaseException so strict mypy does not infer an Any return. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor(connectedk8s): consolidate ARM helpers Parameterize connected-cluster PUT and GET helpers by operation while preserving operation-specific telemetry and error definitions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fixes to telemetry sanitization * dont block onboarding for couldn't check provider registration * fix(connectedk8s): harden telemetry field redaction Redact case-insensitive JSON and key-value credential fields while preserving quoting and avoiding similarly named non-sensitive fields. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: John McCormick <mccormickjo@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add Proxy Pester Tests and restrict Arc bypass on reconnect. (#94) * Announce the Arc proxy bypass only where it reaches the agents * Refuse the Arc proxy bypass while reconnecting * Only treat a complete Arc endpoint set as the proxy bypass * Add end-to-end tests for the proxy bypass * Refuse clearing the Arc proxy bypass while the skip range lists it --------- Co-authored-by: Sai Tareesh Reddy Eppeti <seppeti@microsoft.com> * Update dns result parsing to ignore transient issues (#93) * update dns result parsing to ignore transient issues * ruff * reject invalid IP and take last error --------- Co-authored-by: John McCormick <mccormickjo@microsoft.com> * Client Proxy Error Code Reporting/Telemetry (AZK8S08XX) (#83) * add client proxy error reporting * test(connectedk8s): add client proxy error coverage Cover client proxy error classification, legacy fault aliases, and preserved ARM credential error handling on the proxy-errors branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(connectedk8s): sanitize telemetry error payloads Move recommendation handling to the raising reporter, sanitize event properties and exception messages, and cover apostrophe-bearing proxy failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: John McCormick <mccormickjo@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Add helm override for kube state metrics repository (#95) Add helm override for kube-state-metrics repository * Standardize configuration input errors (AZK8S0100-AZK8S0106) (#92) * Standardize configuration input errors (AZK8S0100-AZK8S0106) * Remove generated test attribution comments * Fix gateway resource ID type checking * Fix connectedk8s unhandled error telemetry coverage (#91) * fix(connectedk8s): standardize unhandled error telemetry * fix(connectedk8s): preserve classified proxy errors in tests * Add ownership tracking for Arc proxy bypass. (#96) * Track Arc proxy bypass ownership * Fix unit tests and ruff formatting --------- Co-authored-by: Sai Tareesh Reddy Eppeti <seppeti@microsoft.com> * chore(connectedk8s): prepare 1.11.4 release * Fix connectedk8s 1.11.4 release review findings (#102) * Sanitize prediagnostic log telemetry * Fix prediagnostic telemetry command context * Preserve proxy bypass compatibility * Patch existing onboarding private key secret * Format proxy bypass compatibility test * Remove legacy Arc proxy skip range alias * Reject removed Arc proxy skip range alias * Revert "Reject removed Arc proxy skip range alias" This reverts commit 6701f1e. * Fix connectedk8s test secret scan (#103) * Fix MCR precheck to use HTTPS (#104) * Revert manual connectedk8s history update * Restore connectedk8s 1.11.4 release history --------- Co-authored-by: john mccormick <123213439+jmccormick7@users.noreply.github.com> Co-authored-by: John McCormick <mccormickjo@microsoft.com> Co-authored-by: shlokpatel57 <shlokpatel@microsoft.com> Co-authored-by: Tareesh <saitareeshreddy12@gmail.com> Co-authored-by: Sai Tareesh Reddy Eppeti <seppeti@microsoft.com> Co-authored-by: junw98 <junweihe@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
./scripts/ci/test_static.shlocally? (pip install pylint flake8required)python scripts/ci/test_index.py -qlocally?