Refactor language parameter mapping in install_from_release.sh#180
Merged
Conversation
naioja
had a problem deploying
to
ScenarioTesting
GitHub Actions
Failure
naioja
had a problem deploying
to
ScenarioTesting
GitHub Actions
Failure
vmarcella
reviewed
Mar 1, 2024
| else | ||
| SCENARIOS="https://github.com/MicrosoftDocs/executable-docs/releases/download/v1.0.1/zh-cn-scenarios.zip" | ||
| fi | ||
| elif [[ ${LANG_ARRAY_1[@]} =~ $MAIN_LANG_PREFIX ]]; then |
Member
There was a problem hiding this comment.
Can we surround these variable accesses with quotations?
Collaborator
Author
There was a problem hiding this comment.
Added required variable quotation.
mbifeld
requested changes
Mar 1, 2024
mbifeld
left a comment
mbifeld
left a comment
Member
There was a problem hiding this comment.
Thanks so much for the fix Adrian! Added a few comments
- L14 setting a default value for SCENARIOS - L21 variable quotation - L21-L53 reworking the logic to choose translations files based on locale passed to the script
mbifeld
approved these changes
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor language parameter mapping in install_from_release.sh for all of translation we offer, including a catch all option.