Repository navigation
Fix 40 pre-existing CA1307/CA1310 StringComparison violations and promote to warning #34
Description
Summary
PR #33 enabled CA1307 (StringComparison for clarity) and CA1310 (StringComparison for correctness) Roslyn analyzers in .editorconfig at suggestion level. There are 40 pre-existing violations across the server codebase that need to be fixed.
Once all violations are resolved, the severity should be promoted from suggestion to warning so they become build-breaking (since TreatWarningsAsErrors is enabled).
Violations by file
| File | Count | Rules |
|---|---|---|
Server/Handlers/HoverHandler/HoverHandler.cs |
12 | CA1307, CA1310 |
Server/Handlers/HoverHandler/SdkDynamicOperationsDiscovery.cs |
12 | CA1307, CA1310 |
Server/Handlers/CompletionHandler/CompletionHandler.cs |
3 | CA1307 |
Server/Handlers/CodeActionHandler/DynamicSchemaCodeActionHandler.cs |
1 | CA1307 |
Server/Services/Api/ApiService.cs |
2 | CA1307 |
| Other files | ~10 | CA1307, CA1310 |
Fix pattern
Add explicit StringComparison parameter to all string calls:
.StartsWith(s)->.StartsWith(s, StringComparison.Ordinal).Contains(s)->.Contains(s, StringComparison.Ordinal).IndexOf(s)->.IndexOf(s, StringComparison.Ordinal).Replace(old, new)->.Replace(old, new, StringComparison.Ordinal).GetHashCode()->.GetHashCode(StringComparison.Ordinal)
Acceptance criteria
- All 40 CA1307/CA1310 violations fixed
- Promote severity from
suggestiontowarningin.editorconfig -
dotnet buildpasses with zero warnings - All tests pass
Activity
fix: Add StringComparison to all string operations and promote CA1307…
fix: Add StringComparison to all string operations and promote CA1307…
fix: Add explicit permissions to CI workflow (code-scanning #1) (#85)