Feature/matugen on startup toggle - #3270
Open
njfletcher215 wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An option (Under Personalization > Theme & Colors > (NEW) Startup Behavior) to allow the user to choose between setting the theme on startup and waiting for an explicit change to the theme.
Label: Generate Theme at Startup
Type: toggle (boolean)
Default state: true (matches current behavior).
This allows users who have heavy matugen hooks to opt out of regenerating their theme every time dms starts, instead only regenerating when the wallpaper actually changes.
Note that the setting was placed immediately after the theme type selection, because it is not appliccable (and thus disabled) for a custom theme ("Custom" or "Browse" selected).
I also deduplicated some code in
Theme.qml:Component.onCompleted(immediately after the guard that was inserted to enforce the setting).Type of change
Related issues
Closes #3257
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings