Skip to content

Fix VPN UI for active transient entries - #2312

Merged
bbedward merged 1 commit into
AvengeMedia:masterfrom
louzt:fix/vpn-transient-active-entries
Apr 30, 2026
Merged

bbedward merged 1 commit into
AvengeMedia:masterfrom
louzt:fix/vpn-transient-active-entries

Conversation

@louzt

@louzt louzt commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes the VPN UI empty-state behavior when the backend reports active VPN or tunnel connections that are not represented as importable profiles.

Fixes #2311

What changed

  • Merge active VPN entries that are missing from the profiles list into the visible VPN model.
  • Mark those entries as transient so the UI can show them without treating them like imported configs.
  • Hide expand and delete actions for transient entries in both the control center popout and Settings.
  • Preserve existing behavior for regular importable VPN profiles.

Validation

  • QML diagnostics reported no errors on the touched files.
  • Repository lint bootstrap succeeded, but the local lint-qml target could not complete in this environment because its qmllint wrapper resolves to a missing Qt5 path.

@louzt

louzt commented Apr 29, 2026

Copy link
Copy Markdown
Contributor Author

I noticed this bug while validating a self-hosted VPN workflow outside the normal UI import path.

In that setup, the backend state detection was already working correctly and the connection showed up as active, but the VPN UI still rendered the empty "No VPN profiles" state because it only reflected importable profile entries.

That made it easier to separate the problem into two parts:

  • backend detection was already correct
  • the UI model was treating importable profiles as the only visible source of truth

This PR is meant to address that UI-side gap without tying the fix to any specific provider or private setup.

@bbedward
bbedward merged commit 23ed795 into AvengeMedia:master Apr 30, 2026
1 check passed
fishman pushed a commit to fishman/DankMaterialShell that referenced this pull request Jul 15, 2026
Co-authored-by: louzt <18044171+louzt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VPN UI ignores active connections without importable profiles

2 participants