Repository navigation
Conversation
Both reproduce only on a developer machine whose profile directory has a space in it, which is why CI never saw either. - The cyclonedx-dotnet arguments were quoted by hand as well as by Tool's ArgumentStringHandler, producing ""C:\Some Dir\proj.csproj"": the OS reads the leading "" as an empty quoted string and the rest as a bare path, so the argument splits at the first space and the tool rejects the remainder with "command or argument not recognized". - The staleness guard compared version strings ordinally. A "12.2" tag keeps its spelling through NuGetVersion.ToString() while pack normalizes the shipped nuspec to "12.2.0", so the guard threw for packages that were in fact current. Both sides now parse as NuGetVersion; versions that do not parse keep the exact-string check, and genuine drift still throws. Ports the two fixes from fix/sbom-version-comparison onto the rewritten generator on main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes two SBOM generation bugs. Both reproduce only where a path contains a space, which is why CI never sees either.
What is the current behavior?
Tool'sArgumentStringHandler, producing""C:\Some Dir\proj.csproj"". The OS reads the leading""as an empty quoted string and the rest as a bare path, so the argument splits at the first space and cyclonedx-dotnet rejects the remainder with "command or argument not recognized".EnrichRootComponent's staleness guard compares version strings ordinally. A12.2tag keeps its spelling throughNuGetVersion.ToString()while pack normalizes the shipped nuspec to12.2.0, so the guard throws for packages that are in fact current.What is the updated/expected behavior with this PR?
Interpolated values are passed unquoted, matching the Babel and IlMerge calls. The staleness guard parses both sides as
NuGetVersionand compares semantically; versions that do not parse keep the exact-string check, and genuine drift still throws.Checklist
Breaking changes
None.
🤖 Generated with Claude Code