Repository navigation
Try: A block-based version of Mayland - #2802
Conversation
|
I do see header and footer on 9.3.0 but not the fonts 😃 |
|
Yeah, I think the template parts issue is a 9.4 bug. Filed here. |
|
This has been dormant for a while, so here's a fresh set of things that it needs:
cc @scruffian |
ea5d99f to
4286238
Compare
|
I feel like that's a pretty common pattern so should be added to the editor |
|
Yeah, I agree — that should be a variation for the core block. If we do decide to build it in here, I suggest we do it as a block style maybe? |
I'm not sure if a block style is the best idea here since turning off the block style would make it look not so great. I'd say it's best if it's just styled by the theme (I'm talking in terms of just the font sizes and positioning of the links). Hopefully, the block will allow for more styling in the future too. Besides, the issue with the "Previous/Next post" not being a link to the post too can't be solved by a block style either. I opened an issue for the block, which is also a very very new block to be using, so I suppose it will only improve with time (and our contributions, ofc): WordPress/gutenberg#29032 |
|
If it doesn't exist the way we need it to yet, I'd suggest we just leave that post pagination out of the theme and open a ticket to add it later. |
|
I added the issue for the post pagination here and removed the block for the moment |
|
For reference: this Gutenberg issue holds the discussion for implementing letter spacing controls on FSE |
| */ | ||
| function mayland_blocks_scripts() { | ||
| // Enqueue front-end styles. | ||
| wp_enqueue_style( 'mayland-blocks-styles', get_template_directory_uri() . '/style.css' ); |
There was a problem hiding this comment.
Do we need this line? I thought this file was enqueued by default. Also we could just use get_stylesheet_uri...
There was a problem hiding this comment.
Apparently we do, if I remove it it doesn't load automatically
|
|
||
| body { | ||
| -webkit-font-smoothing: antialiased; | ||
| -moz-osx-font-smoothing: grayscale; |
There was a problem hiding this comment.
This feels like it should be part of Gutenberg
There was a problem hiding this comment.
Not sure if every theme will want to have this on their stylesheet, feels like something we want for this specific font family.
What is under /* Set editor widths. */ would be something we'd be able to remove once the alignment PR lands most likely.
The rest of the styles (header spacing and letter spacing) are dependant on WordPress/gutenberg#23294 and WordPress/gutenberg#23228 respectively
scruffian
left a comment
There was a problem hiding this comment.
This looks good. I think everything in style.css should be in Gutenberg somehow, so it would be good to have issues for it if there aren't already.
|
This is a list of the editor issues that are affecting this theme:
|
danieldudzic
left a comment
There was a problem hiding this comment.
I didn't find any blockers for the launch :)
Just a few issues with the frontend styling:
-
Layout Grid columns are displaying one under another
Screenshots: https://cldup.com/BwY5yx1W2S.png / https://cldup.com/cnI7FwSEtZ.png -
Button styling issue
Screenshots: https://cldup.com/oHi6rbHij4.png / https://cldup.com/B7j0OfyOyZ.png -
Contact form missing styling: https://cldup.com/BZUulYROfK.png
f6ca1eb to
09dbe87
Compare




This PR is the beginnings of a block-based version of Mayland.
Screenshots