This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Repository navigation
Fix poor CameraX resolution choice - #128
Merged
mzorz merged 5 commits intoSep 16, 2019
Merged
Conversation
…ew CameraUtils class
…ution to CameraX PreviewConfig
Contributor
Author
|
Going to merge and continue for the demo! |
This was referenced Sep 16, 2019
aforcier
reviewed
Sep 30, 2019
| CompareSizesByArea() | ||
| ) | ||
|
|
||
| // Danger, W.R.! Attempting to use too large a preview size could exceed the camera |
Contributor
Author
There was a problem hiding this comment.
😅 it actually comes from this line in the Camera2 sample app
Collaborator
|
Pixel 3, Android 10 (device) |
This was referenced Nov 6, 2019
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following observed problems on the Samsung S8 handset with Android 9:
The trick here was that we were passing a target aspect ratio to CameraX's PreviewConfig to request it to calculate it for us, but internally this would lead to a bad choice of the best available supported resolution match.
So we're now calculating the optimal size the same way we do on our Camera2 implementation, which is now added as an Utils class in
CameraUtils.kt