Repository navigation
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Premium Analytics plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
… scroll area wp-admin grows #wpwrap to the admin menu's height, so a menu taller than the window makes the document scrollable. With the shell scrolling internally as well, one wheel gesture latched to whichever scroller it was over and stalled at that scroller's end, and the document scroll dragged the whole app off-screen. Let the page be the only scroll container on desktop. The pinned page header and section header keep their current behaviour, now offset against the viewport: admin-ui pins its header at 0, and the section header rests below it using a height the page publishes rather than a restated constant. The guard against removing the panel's scroller (widget-resize flicker) no longer applies: @wordpress/grid takes a fixed pixel rowHeight, and a sampled resize drag showed no oscillation.
ab428c8 to
84cb861
Compare
Fixes WOOA7S-1991
Proposed changes
wp-admin grows
#wpwrapto the admin menu's height, so a menu taller than the window makes the document scrollable. The shell also scrolled internally, and a wheel gesture latches to one scroller at a time — so scrolling stalled at whichever end it reached first, and the document scroll dragged the whole app off-screen behind the shell's rounded corners.Pinning the shell (the first approach on this branch) stopped the app moving but left both scrollers in place, so the stall remained. Letting the app's content flow into the page removes the second scroller entirely.
The comment guarding the panel's scroller warned that removing it would make the panel and the widget grid oscillate while resizing a widget. That no longer applies:
@wordpress/gridtakes a fixed pixelrowHeightsnapped to presets, so there is no container-to-grid feedback, and a sampled resize drag (1350 frames) showed the grid height move once, with zero direction reversals.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions