Skip to content

Licensing: replace Button with LinkButton for links - #51562

Merged
simison merged 1 commit into
trunkfrom
update/licensing-link-button
Aug 27, 2026
Merged

simison merged 1 commit into
trunkfrom
update/licensing-link-button

Conversation

@simison

@simison simison commented Aug 25, 2026

Copy link
Copy Markdown
Member

Follow-up to #50348

Proposed changes

  • Replaces workaround of using Button for links with appropiate new LinkButton component.

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

@simison simison changed the title Licensing: replace Button with LinkButton Licensing: replace Button with LinkButton for links Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/licensing-link-button branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/licensing-link-button

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@simison
simison requested a review from dhasilva August 25, 2026 18:10
@simison simison added the Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. label Aug 25, 2026
@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/js-packages/licensing/components/activation-screen-success-info/primary-link/index.jsx 17/21 (80.95%) 2.69% -1 💚

Full summary · PHP report · JS report

@github-actions github-actions Bot added the RNA label Aug 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@CGastrell

Copy link
Copy Markdown
Contributor

Works as described, thanks!

1-view-my-plans 2-configure-social 3-view-scan-results 4-configure-recommend

@CGastrell CGastrell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simison
simison merged commit 630314b into trunk Aug 27, 2026
114 of 117 checks passed
@simison
simison deleted the update/licensing-link-button branch August 27, 2026 09:12
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[JS Package] Licensing Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. RNA [Type] Janitorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants