Skip to content

License activation: use wp-ui components - #48188

Closed
simison wants to merge 9 commits into
trunkfrom
update/activation-screen
Closed

simison wants to merge 9 commits into
trunkfrom
update/activation-screen

Conversation

@simison

@simison simison commented Apr 19, 2026 •

Copy link
Copy Markdown
Member

Part of #48160

Proposed changes

  • Replace all Jetpack components either with wordpress/ui or wordpress/components.
  • Remove all custom styles and rely on components instead.
  • No functional changes

Before

image image

After

image image

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • From My Jetpack, from footer click "activate license"
image
  • Try invalid license, try correct license

@github-actions

github-actions Bot commented Apr 19, 2026 •

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/activation-screen branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/activation-screen
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/activation-screen

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

github-actions Bot commented Apr 19, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 19, 2026
@jp-launch-control

jp-launch-control Bot commented Apr 19, 2026 •

Copy link
Copy Markdown

Code Coverage Summary

Cannot generate coverage summary while tests are failing. 🤐

Please fix the tests, or re-run the Code coverage job if it was something being flaky.

Full summary · PHP report · JS report

@simison
simison force-pushed the update/activation-screen branch from 8d8802a to 51c4883 Compare April 29, 2026 19:38
@simison
simison marked this pull request as ready for review April 29, 2026 19:50
@simison
simison requested review from CGastrell and dhasilva April 29, 2026 19:50
@simison

simison commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

Closing as outdated. If I remember right, this was ready to deploy but just never got reviews (Slack thread p1777492209236549-slack-C0AU2T3BFGS).

I see that it would need significant rebase, so perhaps this screen already got re-done in RSM efforts. Anyway, closing now. FYI @CGastrell @dhasilva

@simison simison closed this Jun 24, 2026
@simison
simison deleted the update/activation-screen branch June 24, 2026 08:39
@github-actions github-actions Bot removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant