Repository navigation
Forms: Fix dropdown field option background color - #43848
Conversation
… or cut into the wrapper element's border
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
|
Thanks for fixing this! |
* Ensure dropdown field native dropdown UI element receives background color on windows * Also inherit border radius so that the select element doesn't overlap or cut into the wrapper element's border




Fixes FORMS-134
I think this problem was introduced in #43674. To fix that issue an extra wrapper was added around the
<select>element, and all the dropdown field styles were applied to this wrapper.To make the
<select>element not obscure those styles its background was set totransparent.On Windows, the native select element can have a background color applied through CSS, but that change meant it was always white and could have contrast issues with light text colors.
This change ensure that the background color is inherited by the select element so that the user specified colors also apply to the Windows native select UI element.
Border radius is also inherited, otherwise the
selectelement's background might overlap its parent element's border.Other information:
Jetpack product discussion
p1749282002478399-slack-C086RGTJT1D
Does this pull request change what data or activity we track or use?
No
Testing instructions: