Repository navigation
Conversation
edanzer
changed the base branch from
trunk
to
update/migrate-form-fields-to-inner-blocks
April 16, 2025 18:17
This comment was marked as resolved.
This comment was marked as resolved.
edanzer
marked this pull request as ready for review
April 16, 2025 18:29
3 tasks
aaronrobertshaw
force-pushed
the
update/migrate-form-fields-to-inner-blocks
branch
from
April 22, 2025 04:37
2d6820b to
3d84a00
Compare
andrewserong
force-pushed
the
update/migrate-form-fields-to-inner-blocks
branch
from
April 28, 2025 00:02
c543a51 to
793a2a9
Compare
talldan
force-pushed
the
update/migrate-form-fields-to-inner-blocks
branch
from
May 5, 2025 05:51
942e010 to
3317f84
Compare
simison
force-pushed
the
update/file-dropzone-block
branch
from
May 6, 2025 13:29
1299b13 to
07c5190
Compare
* initial commit - adding extra markup to the select rendering and fixing positioning of labels * uncommenting * Remove default select border * Update select field rendering to include a wrapper div with the correct class structure for improved styling and consistency in tests. * Update contact form styles to inherit text color and adjust z-index for select wrapper elements * Only run `getAttribute` on select wrapper if there is one * Reinstate padding change * phan me * phanos * whitespace
… to select dropdown and fix z-index (#43721) * Enhance select field transformation by adding default placeholder for input block. Update contact form plugin to correctly reference placeholder attribute. Adjust z-index values in CSS for improved label positioning. * Update z-index values in contact form CSS for improved label positioning and remove redundant styles for outlined fields. * Complete CSS comment * Refactor select field transformation to set placeholder attribute directly from attributes. Remove redundant placeholder handling in inner block creation. * Revert createTextFieldInnerBlocks * Revert experiment. Add default placeholder for select in createTextFieldInnerBlocks * Don't mutate the attributes object * Don't spread optional chaining just in case
…s. Add 'color: unset !important;' to both editor.scss and grunion.css for consistent input appearance. (#43737)
…PACK-262 (#43002) * inital commit - exploratory * do_shortcode * Add test_block_attributes_to_shortcode_attributes_with_styles * add more simple tests * remove unnecessary changes * changelog * LINTO! * Adding WP namespaces * test_gutenblock_render_field_checkbox * Add test for trim * Use optionsdata to presume that block_attributes_to_shortcode_attributes has taken place. Let's test that as a unit * Adding classes and styles in attributes. * block_attributes_to_shortcode_attributes tests * text field which has input and label * Phan complains about \DOMNode::getAttribute. Shut it up. * Try to quiet Phan again by passing a WP_Block instance * Attempt to fix a couple of the code coverage warnings * Try to fix namespace again * Try using the full namespace for the covers annotation instead of the relative name --------- Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
- Ensure block class is added to legend element - Add custom block classes and styles to legend - Tweak default style specificity so global styles can apply
* Fix text input-style field label font size when outlined style is active. * Remove scaling using variable * Fix scaling of multiple option fields when using outlined style * Tidy up styles * Wrap labels * Fix outlined label font size and animation * Fix animation by ensuring top is a valid value * Remove will-change: transform on frontend too. Transform usually does not change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Before, the block would use "group" block as its container
After, the block uses separate "dropzone" block
Other information:
Jetpack product discussion
None.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Enable beta blocks by adding this to your environment:
Add form with file upload field.
Confirm file upload and dropzone look right in editor.
Confirm file upload and dropzone look correct and work as expected on frontend. Add
jetpack-beta-blockssticker via Blog RC to allow file uploads to your site.Refresh the block editor page, and confirm the file upload and dropzone block still load as expected.