Skip to content

[RNMobile] Add Jetpack Tiled Gallery block square layout - #20831

Closed
guarani wants to merge 10 commits into
rnmobile/add/tiled-gallery-blockfrom
rnmobile/add/tiled-gallery-block-square-layout
Closed

guarani wants to merge 10 commits into
rnmobile/add/tiled-gallery-blockfrom
rnmobile/add/tiled-gallery-block-square-layout

Conversation

@guarani

@guarani guarani commented Aug 25, 2021 •

Copy link
Copy Markdown
Contributor

Addresses wordpress-mobile/gutenberg-mobile#3874

Ports the Jetpack Tiled Gallery block to Mobile Gutenberg. It is part of a group of PRs, including this one. They are:

Please note: This PR is currently a work-in-progress implementation and is incomplete (e.g. it does not yet contain changelog changes, PR checks will fail, etc).

Changes proposed in this Pull Request:

  • Adds the Tiled Gallery block port for React Native
  • The native mobile code diverges from the existing web implementation because we chose to use the InnerBlocks API, to follow the Gallery block's recent refactor to use InnerBlocks
Tiled Gallery block in native mobile Gutenberg Inner Image block selected
Tiled Gallery block screenshot (with parent block in selected state) Tiled Gallery block screenshot (with inner Image block in selected state)

Jetpack product discussion

TO-DO

Does this pull request change what data or activity we track or use?

TO-DO

Testing instructions:

TO-DO

@guarani guarani added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] Tiled Gallery [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Aug 25, 2021
@matticbot

Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello guarani! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D65942-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@github-actions

github-actions Bot commented Aug 25, 2021 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • 🔴 Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


🔴 Action required: Please add missing changelog entries for the following projects: projects/plugins/jetpack

Use the Jetpack CLI tool to generate changelog entries by running the following command: jetpack changelog add.
Guidelines: /docs/writing-a-good-changelog-entry.md


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Jetpack plugin:

  • Next scheduled release: September 7, 2021.
  • Scheduled code freeze: August 30, 2021.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 25, 2021
@guarani
guarani changed the base branch from master to rnmobile/add/tiled-gallery-block August 25, 2021 20:41
@guarani
guarani force-pushed the rnmobile/add/tiled-gallery-block branch from db0ac55 to 3ec4ba6 Compare September 1, 2021 22:43
@guarani
guarani marked this pull request as ready for review September 21, 2021 17:19
@guarani

guarani commented Oct 28, 2021

Copy link
Copy Markdown
Contributor Author

I'm closing this PR because all changes found in this PR have either been merged into the rnmobile/add/tiled-gallery-block branch via other PRs or are deemed no longer needed.

@github-actions github-actions Bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Tiled Gallery Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Touches WP.com Files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants