Repository navigation
Admin Page: Move to Core translation functions -- PART 5 - #16503
Merged
Merged
Conversation
21 tasks done
jeherve
force-pushed
the
update/react-dash-wordpress-i18n-part-5
branch
from
July 17, 2020 11:39
ea70ddf to
cc59664
Compare
Base automatically changed from
update/react-plugin-use-wordpress-i18n
to
master
July 17, 2020 16:53
…p wizard This is part 5, follow-up of #13527 Updating all the Setup wizard elements
jeherve
force-pushed
the
update/react-dash-wordpress-i18n-part-5
branch
from
July 17, 2020 17:03
cc59664 to
b0833fd
Compare
Collaborator
This is an automated check which relies on E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16503 |
kraftbj
approved these changes
Jul 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This is part 5, follow-up of #13527. We're moving away from
translateand using the@wordpress/i18npackage instead.This PR focusses on updating one more parts of the dashboard, the Setup wizard.
Note: this PR is open against the branch used for part 1 in #13527 for now, hence the "Do not merge" label. Once the other PR is merged I'll update the base branch for this PR.
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Nothing should change at first sight.
add_filter( 'jetpack_show_setup_wizard', '__return_true' );Proposed changelog entry for your changes: