Skip to content

Admin Page: Move to Core translation functions -- PART 5 - #16503

Merged
kraftbj merged 1 commit into
masterfrom
update/react-dash-wordpress-i18n-part-5
Jul 17, 2020
Merged

kraftbj merged 1 commit into
masterfrom
update/react-dash-wordpress-i18n-part-5

Conversation

@jeherve

@jeherve jeherve commented Jul 16, 2020

Copy link
Copy Markdown
Member

Changes proposed in this Pull Request:

This is part 5, follow-up of #13527. We're moving away from translate and using the @wordpress/i18n package instead.

This PR focusses on updating one more parts of the dashboard, the Setup wizard.

Note: this PR is open against the branch used for part 1 in #13527 for now, hence the "Do not merge" label. Once the other PR is merged I'll update the base branch for this PR.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • N/A

Testing instructions:

Nothing should change at first sight.

  • On a brand new site, before you connect, add the following filter:
    add_filter( 'jetpack_show_setup_wizard', '__return_true' );
  • Connect your site to WordPress.com, and once the connection is successful you'll be prompted to start setup.
  • Follow the steps; you shouldn't see anything odd.

Proposed changelog entry for your changes:

  • TBD

@jeherve jeherve added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Focus] i18n Internationalization / i18n, adaptation to different languages Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal Connect Flow Connection banners, buttons, ... DO NOT MERGE don't merge it! labels Jul 16, 2020
@jeherve jeherve added this to the 8.8 milestone Jul 16, 2020
@jeherve jeherve self-assigned this Jul 16, 2020
@jeherve
jeherve force-pushed the update/react-dash-wordpress-i18n-part-5 branch from ea70ddf to cc59664 Compare July 17, 2020 11:39
Base automatically changed from update/react-plugin-use-wordpress-i18n to master July 17, 2020 16:53
…p wizard

This is part 5, follow-up of #13527

Updating all the Setup wizard elements
@jeherve
jeherve force-pushed the update/react-dash-wordpress-i18n-part-5 branch from cc59664 to b0833fd Compare July 17, 2020 17:03
@jeherve jeherve removed the DO NOT MERGE don't merge it! label Jul 17, 2020
@jetpackbot

Copy link
Copy Markdown
Collaborator
Warnings
⚠️

pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16503

Generated by 🚫 dangerJS against b0833fd

@kraftbj
kraftbj merged commit 9232bfc into master Jul 17, 2020
@kraftbj
kraftbj deleted the update/react-dash-wordpress-i18n-part-5 branch July 17, 2020 18:57
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review This PR is ready for review. labels Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Admin Page React-powered dashboard under the Jetpack menu Connect Flow Connection banners, buttons, ... Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] i18n Internationalization / i18n, adaptation to different languages [Pri] Normal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants