Repository navigation
Dashboard: remove context from plural string - #15933
Conversation
|
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-15933 Scheduled Jetpack release: June 2, 2020. |
kraftbj
left a comment
There was a problem hiding this comment.
What's the timeline to move to the WordPress i18n functions?
In either case, approving, but if we hit additional instances of being slowed down by it before we switch, it may be worth seeing if we can spend a day making it work.
I was hoping to work on this during the next release cycle. I've added the associated PR (#13527) to the 8.7 milestone. |
|
Already in |
Changes proposed in this Pull Request:
This change was introduced in #15795, and while it works well on its own it introduces a small issue whenever we want to gather translations from the Dashboard to send them to translate.wordpress.org.
If it were PHP, the string would use WordPress'
_nxfunction, as we're dealing with a string with a singular/plural variant, and some added context. Unfortunately, the tool we use to extract strings from React to PHP does not support_nxat the moment.I would be tempted to fix our tool to support this, but since we'll be moving away from this approach to translate the React dashboard soon (we'll be relying on
@wordpress/i18npackage instead, and we'll let WordPress do the work of extracting translations), I think it's best if we just avoid relying on_nxfor now; I don't think it's very necessary in this case.Is this a new feature or does it add/remove features to an existing part of Jetpack?
Does this pull request change what data or activity we track or use?
Testing instructions:
Proposed changelog entry for your changes: