Skip to content

Jetpack Scan: Update Scan to Daily Scan. - #15865

Merged
enejb merged 2 commits into
masterfrom
update/jetpack-scan-daily-wording
May 21, 2020
Merged

enejb merged 2 commits into
masterfrom
update/jetpack-scan-daily-wording

Conversation

@enejb

@enejb enejb commented May 20, 2020 •

Copy link
Copy Markdown
Member

Simple change from Jetpack Scan to Jetpack Scan Daily.

We will be using jetpack scan realtime in the future. So it good to be more specific now.
Related: PR

After:
Screen Shot 2020-05-20 at 4 32 27 PM
Screen Shot 2020-05-20 at 4 33 57 PM

Testing instructions:

  • Go to the plans page. Do you see the expected "Daily Scan" as the selection?
  • Once you buy Jetpack Scan Daily. Do you notice the new Jetpack Scan Daily as the product that you purchased.

Proposed changelog entry for your changes:

nothing roll them up to the jepack scan product.

@enejb enejb added this to the 8.6 milestone May 20, 2020
@enejb
enejb requested a review from a team May 20, 2020 14:36
@jetpackbot

jetpackbot commented May 20, 2020 •

Copy link
Copy Markdown
Collaborator
Warnings
⚠️

pre-commit hook was skipped for one or more commits

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against b96511c

@enejb enejb added the [Status] Needs Review This PR is ready for review. label May 20, 2020
@leogermani

Copy link
Copy Markdown
Contributor

Aren't the text-domain params missing from all these i18n functions?

Also, is it better to use sprintf and placeholders instead of {{em}} inside the internationalized string?

@jeherve

jeherve commented May 20, 2020 •

Copy link
Copy Markdown
Member

@leogermani Jetpack's React dashboard still uses wp-calypso's translate functions, and not WordPress' @wordpress/i18n package. That's something we'll update soon, in #13527
Until then, we don't need textdomains and have our own little in-house tool for placeholders.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels May 20, 2020
@enejb
enejb merged commit 9a72345 into master May 21, 2020
@enejb
enejb deleted the update/jetpack-scan-daily-wording branch May 21, 2020 07:04
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants