Repository navigation
Build: Update calypso-build to v4 - #13503
Conversation
|
Caution: This PR has changes that must be merged to WordPress.com |
0955fd9 to
43d1528
Compare
|
sirreal, Your synced wpcom patch D32973-code has been updated. |
|
sirreal, Your synced wpcom patch D32973-code has been updated. |
f125979 to
82975d2
Compare
This is an automated check which relies on |
| module.exports = babelJest.createTransformer( { | ||
| presets: [ | ||
| require.resolve( '@automattic/calypso-build/babel/default' ), | ||
| require.resolve( '@automattic/calypso-build/babel/wordpress-element' ), |
There was a problem hiding this comment.
The @automattic/calypso-build preset provides this transform without this line.
That is something the preset should provide, but I'm not sure of the best way to go about it.
This aligns with the way we pass --env.WP to webpack, but Jest doesn't seem to have any concept of arbitrary arguments we pass through the CLI. In fact, jest fails if it doesn't understand the arguments passed to the CLI.
This is sufficient for now, but it's something that should be considered for future calypso-build work.
|
sirreal, Your synced wpcom patch D32973-code has been updated. |
1 similar comment
|
sirreal, Your synced wpcom patch D32973-code has been updated. |
ockham
left a comment
There was a problem hiding this comment.
This looks great and seems to build and work well (both dashboard and Gutenblocks); thanks a ton for working on this!
One note, I see a weird visual change in a Gridicon (in the Upgrade Nudge) 😖
(Note that the Nudge isn't enabled yet -- I'm enabling it in my dev env through add_filter( 'jetpack_block_editor_enable_upgrade_nudge', '__return_true' );. Probably fine to fix in a follow-up, as long as nothing else is broken -- I couldn't spot anything 😅 )
Could this be related to color-studio changes in Calypso build pipeline? |
| resolved "https://registry.yarnpkg.com/@automattic/calypso-color-schemes/-/calypso-color-schemes-1.0.0.tgz#17a14e3257bd90b40e960d624cca4353d4d20c34" | ||
| integrity sha512-W7r4pgcBauLx65oTLbHKV84ScnfEKmW7T/sXkPfByHhuIE7+OpubmiiBsizWatk1I/puUTmj+SDqEOJMOyRdzA== | ||
|
|
||
| "@automattic/calypso-color-schemes@^2.0.2": |
There was a problem hiding this comment.
@ockham This may be related to the visual change you're seeing…
#13503 (review)
There was a problem hiding this comment.
Yeah… I think this line:
Would need to become --studio-white.
There was a problem hiding this comment.
@porada 👋 where there any other colors than white that now need --studio prefix?
Bummer with CSS variables (as opposite to scss variables) is that they fail silently. :-/
Checked if these would be listed on changelog but no dice:
https://github.com/Automattic/color-studio/blob/4b3262ac652a39c434c818e9e9c357fc23c8c0cc/CHANGELOG.md
There was a problem hiding this comment.
We replaced white with 3 semantic properties:
--color-surface(default white background),--color-text-inverted(white text, which is also the correct substitute for the case mentioned above),--color-border-inverted(white border).
Generally, we should avoid --studio-* values in favor of the theme properties (that’s a full listing).
Bummer with CSS variables (as opposite to scss variables) is that they fail silently
Yes, that is a disadvantage of using CSS properties. I hope we can make Stylelint throw errors when using an undefined property.
Checked if these would be listed on changelog but no dice
Color Studio’s changelog focuses only on color value changes. calypso-color-schemes would be a better place to look this up.
There was a problem hiding this comment.
Opened an issue to separate colors from calypso-build: Automattic/wp-calypso#36466
brbrr
left a comment
There was a problem hiding this comment.
I've done some functional testing, and all looks good. LGTM ![]()
|
sirreal, Your synced wpcom patch D32973-code has been updated. |
|
Cherry-picking yarn.lock didn't really fix the conflict, this needs a rebase. Can one of the authors please rebase when you're happy with the reviews, so that the history doesn't get lost? |
efce591 to
42778df
Compare
|
sirreal, Your synced wpcom patch D32973-code has been updated. |
|
Rebased and yarn.lock regenerated |
kraftbj
left a comment
There was a problem hiding this comment.
Tested with a completely clean yarn build and via JN. No errors in CLI, console, and everything seemed functional.
42778df to
e59c7b3
Compare
|
sirreal, Your synced wpcom patch D32973-code has been updated. |
- Switch Muriel `--color-white` to Gutenberg white - Switch two specific Muriel colors in Mailchimp to Muriel success+error colors like elsewhere in `/extensions/*`
|
sirreal, Your synced wpcom patch D32973-code has been updated. |
|
Aight! I tested several places where CSS variables ( Instead of switching it to
There are still Muriel color variables around these files (such as Most notably, this star and several other "whites" aren't broken anymore (as noted in #13503 (review)): Good for another test from Crew. |
jeherve
left a comment
There was a problem hiding this comment.
This seems to work well for me. 👍


Update
@automattic/calypso-buildto v4. Required for #13490Closes #13594 (the automated dependency upgrade PR).
This updates the
calypso-builddependency to version 4.