feat: add structured settings management (SBP-531) - #132
Open
marius-mather wants to merge 32 commits into
Open
Conversation
…ked at startup now
vtnphan
requested changes
Aug 14, 2026
vtnphan
left a comment
Collaborator
There was a problem hiding this comment.
It's quite big to be review in details, just got one small comment in prerun env as we're gonna remove it soon. The others look good to me. Thank you
Comment on lines
+35
to
+42
| def _aws_prerun_env(settings: Settings) -> dict[str, str]: | ||
| return { | ||
| "AWS_ACCESS_KEY_ID": settings.aws.access_key_id, | ||
| "AWS_SECRET_ACCESS_KEY": settings.aws.secret_access_key, | ||
| "AWS_REGION": settings.aws.region, | ||
| } | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
I think we can skip this as we'll remove the AWS keys in prerun_script in the next PR soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
SBP-531: we have multiple environment variables scattered throughout the code, use
pydantic-settingsto bring them together in a structured way. Benefits:Changes
get_settingsdependency to ensure FastAPI fetches and caches the settingsHow to Test
Run
uv run pytestType of change
Checklist