refactor(app): extract pawwork workspace lifecycle from layout.tsx

[Astro-Han]

Summary

Slice 5 of the layout governance line (#1056). Pure extraction: moves the workspace lifecycle actions out of pages/layout.tsx into a new controller pages/layout/pawwork-workspace-lifecycle.ts.

Extracted (verbatim, input.-prefixed): createWorkspace, createCurrentWorkspace, deleteWorkspace, resetWorkspace, renameWorkspace, toggleCurrentWorkspace. layout.tsx 1530 → 1358.

No user-visible behavior change (DOM / copy / aria / command IDs / storage keys / styles untouched).

Touched files

• packages/app/src/pages/layout.tsx — remove the 6 functions + now-unused imports (clearWorkspaceTerminals re-added and passed as input; clientActionHeaders, effectiveWorkspaceOrder, toaster dropped), wire up the controller destructure.
• packages/app/src/pages/layout/pawwork-workspace-lifecycle.ts — new controller (createPawworkWorkspaceLifecycle).
• packages/app/src/pages/layout/pawwork-workspace-lifecycle.test.ts — 13 new focused tests.

Review focus

• Verbatim equivalence of the 6 extracted functions under input. injection.
• Boundary: setWorkspaceName and renameProject stay in layout.tsx (already injected into the slice-3 project-controls controller → shared primitives, injected here not moved).
• clearWorkspaceTerminals injected, not imported: importing @/context/terminal pulls @solidjs/router, which evals a client-only solid template at module load and breaks the unit test under the server build. Exact type recovered via typeof import("@/context/terminal").clearWorkspaceTerminals (type-only, no runtime load).
• Dead code left untouched: closeProject / toggleProjectWorkspaces have zero references across packages/ — left in place (pure extraction, not cleanup).
• Reactivity / ordering: delete navigates-before-remove when deleting the active workspace; reset clears-terminals → dispose → reset → archive ordering.

Verification

• bun run typecheck 8/8
• cd packages/app && bun test src/pages/layout → 178 pass (165 prior + 13 new)
• eslint clean on changed files

Risk

Low. Mechanical extraction; behavior preserved and covered by the new tests. The only non-mechanical decision is injecting clearWorkspaceTerminals (documented above). #1053 (automation) also touches pages/layout.tsx and will rebase on top.

Refs #1056.

[coderabbitai]

Warning

Review limit reached

@Astro-Han, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 34 minutes and 33 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d12edf08-5e3c-433b-9539-1ea18a53ae7a

📥 Commits

Reviewing files that changed from the base of the PR and between a20f49c and 68bdc31.

📒 Files selected for processing (4)

• packages/app/src/context/global-sync/client-action-source.test.ts
• packages/app/src/pages/layout.tsx
• packages/app/src/pages/layout/pawwork-workspace-lifecycle.test.ts
• packages/app/src/pages/layout/pawwork-workspace-lifecycle.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/layout-workspace-lifecycle

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Suggested priority: P2 (includes user-path files (packages/app/src/pages/layout.tsx, packages/app/src/pages/layout/pawwork-workspace-lifecycle.test.ts, packages/app/src/pages/layout/pawwork-workspace-lifecycle.ts)).

P1/P0 are reserved for maintainer confirmation. Please relabel manually if this is a release blocker, security issue, data-loss risk, or updater/runtime failure.

[gemini-code-assist]

Code Review

This pull request refactors the layout page by extracting workspace lifecycle methods—such as renaming, deleting, resetting, and creating workspaces—into a dedicated createPawworkWorkspaceLifecycle helper, accompanied by comprehensive unit tests. The feedback suggests centralizing active-session filtering and cleanup logic into shared helpers, and using optional chaining defensively when accessing session properties to prevent potential runtime crashes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[Astro-Han]

Re gemini on pawwork-workspace-lifecycle.ts:149 — out of scope for this slice. This PR is a pure, verbatim extraction: the predicate session.time.archived === undefined is copied unchanged from layout.tsx (origin/dev L1003), and the same form appears elsewhere (L1108). Session.time is a non-optional SDK field (typecheck passes without ?.), so optional chaining would guard a state the type rules out. Centralizing the active-session filter into a shared helper is a cross-cutting refactor (it would also have to touch the other call site) and belongs in its own change, not a behavior-preserving extraction. No change here.