Skip to content

fix: code quality and safety improvements #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: code quality and safety improvements #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const shouldEnableRateLimit = () => {
const getRateLimitMax = () => {
// Environment variable override takes precedence
if (process.env.RATE_LIMIT_MAX) {
return parseInt(process.env.RATE_LIMIT_MAX);
return parseInt(process.env.RATE_LIMIT_MAX, 10);
}

// Production: 100 requests per 15 minutes
Expand Down
4 changes: 2 additions & 2 deletions server/routes/questions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ router.get('/', async (req, res) => {
.populate('author', 'username reputation avatar')
.sort(sortOption)
.skip(skip)
.limit(parseInt(limit))
.limit(parseInt(limit, 10))
.lean()

const total = await Question.countDocuments(query)
Expand All @@ -126,7 +126,7 @@ router.get('/', async (req, res) => {
res.json({
questions: questionsWithVirtuals,
pagination: {
currentPage: parseInt(page),
currentPage: parseInt(page, 10),
totalPages,
total,
hasNext: page < totalPages,
Expand Down