Repository navigation
fix: connect metric-stream sinks to Postgres - #3250
Conversation
Retain Redpanda routes and marker contracts. Add typed activity aliases and real physical-erasure regressions. Record the proven publication race as a diagnostic patch; writer integration remains a release blocker.
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Reviewer's GuideConfigurationAdd the existing required Postgres connection to the shared sink environment so all metric-stream sinks can reach the database.
DocumentationRecord the incident’s confirmed root cause, the deployment fix and validation, and the remaining recovery gates.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Mergestorm reviews this repository's pull requestsEvery PR gets AI code review that flags real bugs before they merge. This account's 30 free credits for this monthly window are used, so reviews are paused at The Starter plan includes 120 credits a month. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3250 +/- ##
=======================================
Coverage 97.40% 97.40%
=======================================
Files 1144 1144
Lines 63146 63146
Branches 19617 19617
=======================================
Hits 61505 61505
Misses 1595 1595
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Review Summary (LGTM)The changes provide the missing Key Verifications
🤖 Reviewed by codereviewbot.ai - Catch bugs before your team does. |
The live metric-stream consumer fails owned publication with Postgres ECONNREFUSED after #3234: its production service lacks DATABASE_URL and startup loads the loopback development default. The existing deployment job passed while the consumer was idle, so its successful stability check did not prove the new Postgres dependency.
Add one DATABASE_URL entry to the shared sink environment anchor using the existing required POSTGRES_PASSWORD and db:5432 endpoint. Legacy, live and history sinks inherit it. No runtime code, new secret, timeout, retry, health threshold, offset or manual production change.
Validation: stock workspace Compose rendering reproduces the omission in the original production stack; the corrected production and maintenance overlays resolve the exact synthetic connection for all three sinks; missing POSTGRES_PASSWORD fails interpolation. The CI yamllint command passed on the changed file, and git diff --check passed. Per repository policy, declarative configuration is verified by stock schema-aware tooling instead of static-config unit tests. Final CI and the canonical release must still pass; actual owned consumption and post-release task stability remain recovery gates.
Evidence: original maintenance release, incident record. A names-only live probe confirmed DATABASE_URL and POSTGRES_PASSWORD absent, and a bounded log window traced the first observed batch failure to withOwnedQueries. No production data or settings were changed during diagnosis.
Exact head 6879eec passed CI 42747662690: 75 successful jobs, 22 intentional skips, zero failures, including all four integration shards and full unit coverage. No unresolved review threads. Current main 127fb11 adds independent health-sensor models and leaves the sink environment, owner and callback unchanged; normal main CI remains the combined-tree deployment gate.