Fix numeral scaling for icon_layers without scale specification - #575
Merged
Conversation
kirazy
commented
Apr 5, 2021
Contributor
- Adjusted precendence for icons vs icon, moved return icons above return icon in function get_icons()
- Baked 0.5 scaling factor into icon_size_scale calculation for instances where scale is specified, and where it is not, icon_size_scale is 0.5.
- Added brackets around 10.24 / 32 on line 172 to make parser happy
- Cleaned up trailing whitespace
1. Adjusted precendence for icons vs icon, moved return icons above return icon in function get_icons() 2. Baked 0.5 scaling factor into icon_size_scale calculation for instances where scale is specified, and where it is not, icon_size_scale is 0.5. 3. Added brackets around 10.24 / 32 on line 172 to make parser happy 4. Cleaned up trailing whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.