Feat/token invalidation

[ppoliani]

• Added logic to invalidate user tokens Implement auth token invalidation logic #336
• Remove the is_banned check on every request Avoid checking is user is banned on every request #337
• Tackles the considerations raised here auth: move away from JWT #311

Continuation of this PR #335

PENDING add automated tests

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/token_invalidation

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[FrenchGithubUser]

That looks nice!

So if I understand it well, the validity of the tokens is stored in a redis db and we don't need to access the pg db at every request anymore ?

In this case, it is indeed fine to have some data (other than user id) in the token. We will need to invalidate the token when we mutate some of this data.

One consideration I have is the added <R: RedisPoolInterface + 'static> at most handlers, I'm not sure exactly what it means (I'm not so familiar with lifetimes) and why it's needed. Also, if there's a less verbose syntax, that'd be nice (yes again, I'm into not-so-verbose syntax for those things).

[ppoliani]

We will need to invalidate the token when we mutate some of this data.

Exactly. And we can also allow a true user logout as well using this approach.

The generic that was added is the rust type system in action. More specifically we use traits and not specific types so we can easily tests using mocks and easily replace the specify trait
Implementation with little code changes.

In rust once you enter the generics realm you will end up with somewhat verbose syntax. I personally don't see it this way, I like how explicit the rust type system is but I can understand why people find it verbose 😂

[FrenchGithubUser]

I see, this makes sense!

[FrenchGithubUser]

very nice!