Configure deployment for java 17 to ghrcr

[robfrank]

This pull request includes significant changes to the Maven configuration and CI workflows. The most important updates involve removing Maven Central publishing configurations, adding GitHub Package Registry support, and simplifying the CI workflows by removing unused secrets and steps.

Maven Configuration Updates:

• pom.xml: Added distributionManagement to configure publishing to the GitHub Package Registry and replaced the Maven Central publishing plugin with the maven-deploy-plugin for deployment. Removed the central-publishing-maven-plugin configuration. [1] [2] [3]

• package/pom.xml: Specified ghcr.io as the Docker registry for image publishing.

CI Workflow Simplifications:

• .github/workflows/mvn-deploy.yml: Removed the entire workflow for deploying to Maven Central and Docker Hub, including steps for Docker setup, Maven configuration, and E2E testing.

• .github/workflows/mvn-release.yml: Removed unused secrets (MAVEN_USERNAME, MAVEN_PASSWORD, DOCKER_USERNAME, DOCKER_PASSWORD) and simplified the Maven release configuration. [1] [2]

[gemini-code-assist]

Hello @robfrank, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a summary of this pull request. This PR, authored by robfrank, focuses on migrating the project's deployment strategy from Maven Central and Docker Hub to the GitHub Package Registry (GHCR). The changes involve updating Maven configuration files (pom.xml and package/pom.xml) to point to GHCR for both Maven artifacts and Docker images, and simplifying the associated GitHub Actions workflows by removing configurations and secrets related to the old deployment targets.

Highlights

• Docker Image Publishing to GHCR: The Docker image build and publishing process is updated to target ghcr.io, the GitHub Container Registry, by adding the <registry> configuration in package/pom.xml.
• Removal of Maven Central Configuration: The central-publishing-maven-plugin configuration has been removed from the main pom.xml, eliminating the setup for publishing to Maven Central.
• CI Workflow Simplification: Related GitHub Actions workflows (mvn-deploy.yml and mvn-release.yml) are simplified by removing steps and secrets previously used for deploying to Maven Central and Docker Hub, streamlining the CI/CD process for the new GHCR target.

Changelog

Click here to see the changelog

• .github/workflows/mvn-deploy.yml
  • Removed the entire workflow file, which was previously used for deploying to Maven Central and Docker Hub.
• .github/workflows/mvn-release.yml
  • Removed unused secrets (MAVEN_USERNAME, MAVEN_PASSWORD, DOCKER_USERNAME, DOCKER_PASSWORD) and simplified the Maven release configuration related to the old deployment setup.
• package/pom.xml
  • Added <registry>ghcr.io</registry> configuration to the docker-maven-plugin to specify the GitHub Container Registry as the target for Docker image publishing (around line 292).
• pom.xml
  • Added <distributionManagement> section to configure the GitHub Package Registry as the deployment repository for Maven artifacts (around line 107).
  • Added the maven-deploy-plugin configuration with <deployAtEnd>true</deployAtEnd> to handle artifact deployment to the configured repository (around line 250).
  • Removed the central-publishing-maven-plugin configuration, discontinuing support for publishing to Maven Central (around line 269).
  • Added a blank line for formatting before the maven-jar-plugin configuration (around line 293).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Maven builds the code,
Docker packs it up tight,
GHCR awaits.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively updates the Maven configuration to publish artifacts to GitHub Packages and Docker images to GitHub Container Registry (GHCR). The changes are well-described and align with the goal of centralizing artifact management on GitHub. The removal of old deployment configurations and unused secrets in CI workflows (as mentioned in the description) are positive steps for simplification and security.

I've found one high-severity issue related to the deployment of SNAPSHOT versions that needs addressing. Otherwise, the changes look good.

Please ensure that the CI environment's settings.xml (or equivalent mechanism) is correctly configured with a server entry for <id>github</id> to provide authentication credentials (typically a GITHUB_TOKEN) for deploying to GitHub Packages.

Summary of Findings

• Missing Snapshot Repository Configuration: The pom.xml is missing a <snapshotRepository> within the distributionManagement section. This is required for deploying SNAPSHOT versions of artifacts, and its absence will likely cause deployment failures for the current -SNAPSHOT version of the project.
• Whitespace Change (Low Severity - Not Commented): A minor whitespace change (an added empty line) was found in pom.xml (Diff 4). This is a low-severity stylistic change and was not commented on due to review settings.

Merge Readiness

The pull request makes significant progress in reconfiguring the deployment to GitHub. However, due to the high-severity issue identified (missing <snapshotRepository> configuration in pom.xml), I recommend that this change be addressed before merging to ensure that SNAPSHOT deployments function correctly. I am not authorized to approve pull requests, so please ensure further review and approval by authorized maintainers after addressing the feedback. Once the suggested change is made, the PR should be in good shape for merging.