Skip to content

Decrease distance bars to match stock Honda behavior - #7

Merged
Aragon7777 merged 1 commit into
Aragon7777:0.8.10-model-0.8.9-release-hondafrom
steveham3:development
Oct 24, 2021
Merged

Aragon7777 merged 1 commit into
Aragon7777:0.8.10-model-0.8.9-release-hondafrom
steveham3:development

Conversation

@steveham3

@steveham3 steveham3 commented Oct 23, 2021

Copy link
Copy Markdown

Self explanatory.

Other commits I have on my default branch that you may like include:

  • Enable LKAS if Set or Resume is pressed (may be useful to have this option on a toggle)
  • Allow LKAS below engage speed (otherwise it won't re-engage when you release the brake under 25mph)

@Aragon7777

Copy link
Copy Markdown
Owner

I will experiment with this on my personal civic branch.

  • Enable LKAS if Set or Resume is pressed in addition to the LKAS button (may be useful to have this option on a toggle)

Sounds good. I like that idea, a lot.

  • Allow LKAS below engage speed (otherwise it won't re-engage when you release the brake under 25mph)

This issue affects all Hondas without stop & go and without a pedal, I noticed that on my Honda Pilot as well. Thanks for fixing that long standing issue.

As for your main PR commit, the distance bars were actually done backwards on purpose because on the civic, bars 3 and 4 became broken if the order was changed in the normal direction. Broken as in, brakes get permanently stuck on the moment a lead comes onto the radar. This might be fixed now that follow_helpers.py exists, so I'll have to try it again.

@steveham3

Copy link
Copy Markdown
Author

Interesting about the problem with the Civic. Want me to create separate PRs for the two LKAS commits on your personal branch?

@Aragon7777

Copy link
Copy Markdown
Owner

I already cherry-picked them. Interestingly, the old issues with the distance selector being ordered in the stock way are fixed! I also did a toggle for the enabling ACC doing LKAS.

@Aragon7777
Aragon7777 merged commit d5f95c1 into Aragon7777:0.8.10-model-0.8.9-release-honda Oct 24, 2021
@steveham3
steveham3 deleted the development branch October 24, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants