Skip to content

Fix CS7035 warning in dependabot jobs#2849

Merged
martincostello merged 2 commits into
mainfrom
fix-CS7035
Dec 4, 2025
Merged

Fix CS7035 warning in dependabot jobs#2849
martincostello merged 2 commits into
mainfrom
fix-CS7035

Conversation

@martincostello

Copy link
Copy Markdown
Member

Fix CS7035 warnings from $GITHUB_RUN_NUMBER not being set when dependabot jobs run.

Fix `CS7035` warnings from `$GITHUB_RUN_NUMBER` not being set when dependabot jobs run.
Copilot AI review requested due to automatic review settings December 4, 2025 17:03
@martincostello martincostello enabled auto-merge (squash) December 4, 2025 17:03
@codecov

codecov Bot commented Dec 4, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.15%. Comparing base (a83d82c) to head (fd50ba6).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2849   +/-   ##
=======================================
  Coverage   96.15%   96.15%           
=======================================
  Files         309      309           
  Lines        7127     7127           
  Branches     1005     1005           
=======================================
  Hits         6853     6853           
  Misses        221      221           
  Partials       53       53           
Flag Coverage Δ
linux 96.15% <ø> (ø)
macos 96.15% <ø> (ø)
windows 96.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CS7035 warnings that occur during dependabot jobs when the GITHUB_RUN_NUMBER environment variable is not set. The fix wraps the variable reference with MSBuild's ValueOrDefault function to provide a fallback value of '0'.

  • Wraps GITHUB_RUN_NUMBER with ValueOrDefault('$(GITHUB_RUN_NUMBER)', '0') in the FileVersion property to prevent build warnings when the environment variable is not available

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread eng/Common.targets Outdated
Comment thread eng/Common.targets Outdated
Fix another instance that needed updating.
@martincostello martincostello merged commit 5a093a1 into main Dec 4, 2025
28 checks passed
@martincostello martincostello deleted the fix-CS7035 branch December 4, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants