Skip to content

[Docs] Dispose registry which contains rate limiters#2578

Merged
martincostello merged 7 commits into
App-vNext:mainfrom
peter-csala:2425-documentation
Apr 11, 2025
Merged

[Docs] Dispose registry which contains rate limiters#2578
martincostello merged 7 commits into
App-vNext:mainfrom
peter-csala:2425-documentation

Conversation

@peter-csala

@peter-csala peter-csala commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

Done

  • Lift and shift (code sample and documentation fragment)
  • Optimized the sample code a bit

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov

codecov Bot commented Apr 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (db5d21c) to head (4ee33bf).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2578   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7327     7327           
  Branches     1013     1013           
=======================================
  Hits         7051     7051           
  Misses        222      222           
  Partials       54       54           
Flag Coverage Δ
linux 96.23% <ø> (ø)
macos 96.23% <ø> (ø)
windows 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peter-csala peter-csala changed the title [Draft] [Docs] Dispose registry which contains rate limiters [Docs] Dispose registry which contains rate limiters Apr 11, 2025
@peter-csala peter-csala marked this pull request as ready for review April 11, 2025 06:40

@martincostello martincostello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a few minor suggested tweaks.

Comment thread docs/pipelines/resilience-pipeline-registry.md Outdated
Comment thread docs/pipelines/resilience-pipeline-registry.md Outdated
Comment thread docs/pipelines/resilience-pipeline-registry.md Outdated
peter-csala and others added 2 commits April 11, 2025 13:04
Co-authored-by: Martin Costello <martin@martincostello.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants