Skip to content

Fix Retry strategy ShouldHandle in example code#2527

Merged
martincostello merged 3 commits into
App-vNext:mainfrom
marcrocny:marcrocny-retry-doc-fix
Apr 7, 2025
Merged

Fix Retry strategy ShouldHandle in example code#2527
martincostello merged 3 commits into
App-vNext:mainfrom
marcrocny:marcrocny-retry-doc-fix

Conversation

@marcrocny

Copy link
Copy Markdown
Contributor

Pull Request

The issue or feature being addressed

The existing example compiles, but incorrectly shows the ShouldHandle delegate as operating on an Exception object.

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • N/A, doc only I have included unit tests for the issue/feature
  • N/A, doc only I have successfully run a local build

@marcrocny

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@martincostello

Copy link
Copy Markdown
Member

Thanks for the PR.

You'll need to change the code in the Snippets, which are used to generate the docs, otherwise the changes will get overwritten.

Once you've done that the docs can be regenerated with:

dotnet tool restore
dotnet mdsnippets

@marcrocny

Copy link
Copy Markdown
Contributor Author

@martincostello Thanks for the pointer, good to go now?

@martincostello

martincostello commented Apr 5, 2025

Copy link
Copy Markdown
Member

Looks like the snippet doesn't compile because it raises a nullability warning.

@marcrocny marcrocny force-pushed the marcrocny-retry-doc-fix branch from 6cc99ae to a1cb5f3 Compare April 6, 2025 23:19
@codecov

codecov Bot commented Apr 7, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.23%. Comparing base (3fb0897) to head (a1cb5f3).
Report is 35 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2527   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7327     7327           
  Branches     1013     1013           
=======================================
  Hits         7051     7051           
  Misses        222      222           
  Partials       54       54           
Flag Coverage Δ
linux 96.23% <ø> (ø)
macos 96.23% <ø> (ø)
windows 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martincostello martincostello enabled auto-merge (squash) April 7, 2025 07:20
@martincostello martincostello merged commit f55880c into App-vNext:main Apr 7, 2025
martincostello added a commit that referenced this pull request Apr 7, 2025
Tweak the code formatting for changes from #2527.
martincostello added a commit that referenced this pull request Apr 7, 2025
Tweak the code formatting for changes from #2527.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants