Fix Retry strategy ShouldHandle in example code#2527
Merged
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
Member
|
Thanks for the PR. You'll need to change the code in the Snippets, which are used to generate the docs, otherwise the changes will get overwritten. Once you've done that the docs can be regenerated with: |
Contributor
Author
|
@martincostello Thanks for the pointer, good to go now? |
Member
|
Looks like the snippet doesn't compile because it raises a nullability warning. |
6cc99ae to
a1cb5f3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2527 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7327 7327
Branches 1013 1013
=======================================
Hits 7051 7051
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martincostello
approved these changes
Apr 7, 2025
martincostello
added a commit
that referenced
this pull request
Apr 7, 2025
Tweak the code formatting for changes from #2527.
Merged
martincostello
added a commit
that referenced
this pull request
Apr 7, 2025
Tweak the code formatting for changes from #2527.
This was referenced Nov 24, 2025
Open
This was referenced Dec 8, 2025
This was referenced Jun 2, 2026
This was referenced Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
The existing example compiles, but incorrectly shows the
ShouldHandledelegate as operating on an Exception object.Details on the issue fix or feature implementation
Confirm the following