Skip to content

fix(app): return an empty icon manifest before the first data sync #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ApocDev merged 1 commit into from
Jul 1, 2026
+8 −1
Merged

fix(app): return an empty icon manifest before the first data sync #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/src/server/factorio.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,7 +1875,14 @@ export const iconManifestFn = createServerFn({ method: "GET" }).handler(
const fs = await import("node:fs/promises");
const path = await import("node:path");
const { ICON_DATA_DIR } = await import("./paths.ts");
const raw = await fs.readFile(path.join(ICON_DATA_DIR, "manifest.json"), "utf8");
let raw: string;
try {
raw = await fs.readFile(path.join(ICON_DATA_DIR, "manifest.json"), "utf8");
} catch {
// No atlas yet (a fresh install, before the first data sync) — return an empty
// manifest so icons fall back gracefully instead of surfacing an ENOENT.
return { cell: 0, atlasSize: 0, sheets: [], icons: {} };
}
// file content is untyped input — assert the shape at this boundary only
const manifest = JSON.parse(raw) as IconManifest;
// Cache-bust the atlas sheets: the PNGs are served at stable URLs (/icons/
Expand Down
Loading