Skip to content

fix(desktop): kill the node sidecar before self-update restart #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ApocDev merged 1 commit into from
Jul 1, 2026
Merged

fix(desktop): kill the node sidecar before self-update restart #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions app/src-tauri/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,15 @@ async fn updater_install(
)
.await
.map_err(|e| e.to_string())?;
// Kill the node sidecar before relaunching; restart() may not run the Exit
// handler, and a lingering server would hold port 34115 and break the new
// instance's own sidecar.
#[cfg(not(debug_assertions))]
if let Some(state) = app.try_state::<ServerChild>() {
if let Some(child) = state.0.lock().unwrap().take() {
let _ = child.kill();
}
}
app.restart()
}

Expand Down
Loading