fix(app): return an empty icon manifest before the first data sync#65
Merged
Conversation
iconManifestFn read manifest.json unconditionally, so a fresh install (no atlas yet) surfaced an ENOENT to the client on every launch. Return an empty manifest instead — icons fall back gracefully until a data sync builds the atlas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a fresh install (no icon atlas built yet),
iconManifestFnreadmanifest.jsonunconditionally and threwENOENT, surfacing an error to the client on every launch (visible in the console of a brand-new desktop install). Guard the read and return an empty manifest so icons fall back gracefully until a data sync builds the atlas.Doubles as the version bump for a
v0.4.5so the (now working) in-app updater onv0.4.4has a newer release to detect end-to-end.