fix(desktop): kill the node sidecar before self-update restart#61
Merged
Conversation
app.restart() may not run the RunEvent::Exit handler, so the sidecar server could linger and hold port 34115 — breaking the relaunched (updated) instance's own server. Kill it explicitly before restarting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a self-update, updater_install calls app.restart() — but that may not run the RunEvent::Exit handler that kills the node sidecar. A lingering sidecar would keep port 34115, so the relaunched (updated) instance could fail to start its own server (the same stale-process class of bug that plagued manual testing). Kill the sidecar explicitly before restart.