Repository navigation
fix(mobile): Android new-thread composer no longer opens shifted off-screen - #43
Merged
Merged
Conversation
…screen The new-task draft, environment, and branch routes showed the native header on first layout and hid it after mount, which can leave Android content measured with the header. Hide it from the first layout, as DETAIL_HEADER_OPTIONS already does for detail panes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Andrey170170
added a commit
that referenced
this pull request
Oct 26, 2026
Merges upstream's latest published nightly, v0.1.3-nightly.20261026.3726 (3f94487), rather than the tip of main. Adaptations: - ws.ts: rebuilt from upstream's file. Upstream now splits handlers into two groups to stay under TypeScript's instantiation limit; that split is built from CoreWsRpcGroup and the side-chat layer stays beside it. Re-applied availableUpdateVersion in the server config and its snapshot stream, which now passes upstream's workspaceSnapshotsOnDemand option. - PR watch: the fork's 👍 wake and upstream's no-checks wake are combined. The reactor's queued-wake folding passes `now` through to the evaluator, and the test helpers wrap the new signature. - Stack.tsx: upstream removed the new-task sheet stack the Android header fix (#43) patched. Its Environment and Branch routes now use DETAIL_HEADER_OPTIONS so Android hides the native header from first layout. - SideChatPanel: upstream replaced onManualNavigation with a viewport navigation signal (pingdotgg#25463); the side chat releases live follow through onViewportAttach and navigationReleasesFollow. Its two effects carry the justification upstream's react-effect-budget rule asks for. - useComposerStash: the side-chat guard moved into upstream's registered Mod+S handler. - TimelineAssistantRows: the fork button keeps the fork's outer gate, which skips the support lookup where forking is unavailable. - SideChatService and PullRequestWatchReactor helpers use Effect.fn, now that upstream makes effectFnOpportunity an error. - pullRequestWatch.forgejoComments.test.ts: removed with upstream, which moved forge tests into their package (pingdotgg#24000). - Dropped the @types/hast override: upstream resolves one copy without it. - upstream-sync skill: target the latest published nightly; typecheck with tsc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Android, the new-thread screen could open shifted down by about one header height, with the composer partly off-screen so you couldn't type. Re-picking the project fixed it.
The new-task routes showed the native header on first layout, and the screens hid it after mount. That's the same race pingdotgg#18963 fixed for detail panes with
DETAIL_HEADER_OPTIONS. The fix hides the native header from the first layout on these routes:All three already draw their own
AndroidScreenHeader. iOS is unchanged.Evidence
After: not yet checked on a device. The fix will ship in the next Forgejo Android build for a device check. Mobile typecheck and lint pass.
Merge Danger
Door: two-way
Blast Radius: small
Only changes Android header options for three new-task routes.
🤖 Generated with Claude Code