NULL_OBJ now is false in truthy check#696
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to the
NULL_OBJimplementation inooodev/utils/gen_util.py, version bump inpyproject.toml, and the addition of new tests.Updates to
NULL_OBJ:ooodev/utils/gen_util.py: Replaced theNULL_OBJconstant with a class_null_objthat overrides the__bool__method to returnFalse. This ensuresNULL_OBJevaluates toFalsein boolean contexts.Version bump:
pyproject.toml: Updated the version from0.52.4to0.52.5.New tests:
tests/test_utils/test_null_obj.py: Added tests to verify the behavior ofNULL_OBJ, ensuring it evaluates toFalsein boolean contexts, is notNone, and that multiple references point to the same instance.