Repository navigation
feat: improve mobile UI primitives - #373
Closed
cahangeorge wants to merge 1 commit into
Closed
cahangeorge wants to merge 1 commit into
cahangeorge wants to merge 1 commit into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
|
Hi @cahangeorge, 感谢这次贡献。这个 PR 和同一批的 #372–#379 先关闭,暂不继续审。 原因:
#371 里 谢谢。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm run check:boundariesnpm run lintnpm run typechecknpm run test:run(103 Vitest files / 1023 tests; Electron MCP 24; Electron plugins 91; versioning 10)npm run build(legacy entry 998.58 KiB, limit 3000 KiB)git diff --checkScope checklist
persisted data (Store keys,
version,partialize,migrate,merge— seesrc/store/persistence/options.tsand ADR 0001), or user-visible UI, describe thechange and its migration impact below. Architecture-enforcement PRs should have none.
importof a business service directly intosrc/components/**(the ESLint
no-restricted-imports/no-restricted-syntaxrules andcheck:boundariesenforce this, including dynamicimport(); if a componentgenuinely needs a service, add a hook in
src/features/*/hooks/**).importof React/JSX/the Store/any service intosrc/features/*/application/**(static or dynamic).
eslint-disableto bypass the boundary rules — fix the layering instead.Runtime / persistence / UI changes (if any)
Shared controls now use 44-pixel mobile targets and 16-pixel form text below the
smbreakpoint, then return to the existing compact desktop dimensions. Overlay primitives
use dynamic viewport bounds, scrolling, and safe-area-aware spacing. There are no data,
Store, or persistence changes and no migration is required.
Notes for reviewers / CodeRabbit
This PR intentionally stays at the shared primitive layer; view-specific responsive
changes are kept out of scope so the behavior can be reviewed independently.