[Request] Add support for resources on the clickhouse-logs container

[honghainguyen777]

We are currently using the ClickHouse Server Helm chart with the operator enabled (https://github.com/Altinity/helm-charts/tree/main/charts/clickhouse). However, we are unable to set resource limits for the clickhouse-logs container, and our Kubernetes cluster requires all containers to have resource requests and limits defined.

Could you please add support for this?

Thank you!

[alex-zaitsev]

@honghainguyen777 , could you elaborate? Are you deploying clickhouse-logs container using 'extraContainers'?

[honghainguyen777]

@alex-zaitsev Hi, sorry for responding you lately. No, we are not deploying clickhouse-logs container using extraContainers. We are currently using the clickhouse-server chart with the operator enabled. In the chart, we have clickhouse.persistence.logs.enabled. By enabling the logs persistence volume, the clickhouse-logs container is added to the cli-clickhouse-server StatefulSet. However, by searching, I found out that the container is coming from the ClickHouseInstallation defined in

clickhouse-operator/pkg/model/chi/creator/container.go

Lines 133 to 145 in 8292064

	// newDefaultContainerLog returns default ClickHouse Log Container
	func (cm *ContainerManager) newDefaultContainerLog() core.Container {
	return core.Container{
	Name: config.ClickHouseLogContainerName,
	Image: config.DefaultUbiDockerImage,
	Command: []string{
	"/bin/sh", "-c", "--",
	},
	Args: []string{
	"while true; do sleep 30; done;",
	},
	}
	}

like in this example (https://github.com/Altinity/clickhouse-operator/blob/master/tests/e2e/manifests/chi/test-043-0-logs-container-customizing.yaml).