Fix modsign macro to fail build on signing errors#219
Open
andrewlukoshko wants to merge 2 commits intoAlmaLinux:masterfrom
Open
Fix modsign macro to fail build on signing errors#219andrewlukoshko wants to merge 2 commits intoAlmaLinux:masterfrom
andrewlukoshko wants to merge 2 commits intoAlmaLinux:masterfrom
Conversation
Replace find -exec with xargs in __brp_kmod_sign so that a non-zero exit from modsign (e.g. unknown OS returning HTTP 400) propagates and aborts the RPM build instead of silently packaging unsigned modules.
Replace find -print -exec rm -f {} with find -delete to avoid
forking rm for each file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace find -exec with xargs in __brp_kmod_sign so that a non-zero exit from modsign (e.g. unknown OS returning HTTP 400) propagates and aborts the RPM build instead of silently packaging unsigned modules.