Repository navigation
#5436 Add "Hide Exact Location" - #5437
benhartwich wants to merge 8 commits into
Conversation
|
Putting Can Sorry, I should have been clear when I asked about this, let's target v2026.10.01_02. On the Discord server we talked about prompting to upload other data as well that would only be used by the Allsky team and not appear on the map. For example, an email address and some yet-to-be-defined usage data. So the prompts would be for the Map data, an email address, and usage data (would need a better name). If we had multiple prompts, should each one have a "declined" setting, or should there be one setting with multiple semi-colon separated fields? Do these changes make sense? |
|
Thanks, done in f92e283:
On the other ideas:
I'd suggest doing those in a separate PR once this one is merged, so this one stays small. Should I start on that? A name for the usage data could be "anonymous usage statistics". |
|
Thanks for the changes Ben. I agree with your other ideas. Not in this PR, but shouldn't I like the name "Privacy & Sharing" for the new WebUI section. I'm thinking all the Map fields should go there, ideally in an "AllskyMap" subsection. The other settings could go in an "Anonymous Data" subsection. "anonymous usage statistics" is long for a setting label in the WebUI, especially on phones. How about "Usage Data"? If you could start on this I'd appreciate it. _01 should be out 1 November at which point Alex will create _02. |
|
Agreed on all points, "Usage Data" it is. I'll start on it in a new branch on top of this PR. Plan
Questions before I add the two new settings
Items 1 and 3 (for the Map) and 4 don't depend on these answers, so I'll do them first. |
To the Allsky Map server (thomasjacquin.com). I'll create a new
Deletion requests: Can we use a URL to a new page that lists the data the user is sharing along with a "delete" button that would send a request to a new Controller: The core Allsky team. Can the GitHub/Discussions URL be used?
It's so the Allsky developers can contact users when we notice a problem with their data or have a question about their data and/or setup. While looking at the map data and noticing something strange, I've wished I had a way to contact the user. |
…de Exact Location" - install.sh asks if the camera should be added to the Allsky Map when it isn't on it. The default is "No"; if the user keeps it, the date is saved in the new "showonmapdeclined" setting and they aren't asked again for a year. "Yes" also asks about hiding the exact location, then runs makeChanges.sh like the WebUI does. - New "Hide Exact Location" setting, right after Latitude and Longitude. When on, the Allsky Map and the local and remote Websites get the latitude and longitude rounded to 1 decimal place; the settings file keeps the exact values. - New getPublicLatLong() in functions.sh, used by postToMap.sh, makeChanges.sh, and when new Website configuration files are created. - postToMap.sh also rounds the location in the settings and Website configuration it sends to the map server. - Documentation and changelog. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCB72NisBJbcYhWokSnGH7
…e same for all cameras update_all_settings_files() updates a setting in the settings file and in all camera-specific settings files. install.sh and makeChanges.sh use it for showonmap, showonmapdeclined, and hideexactlocation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCB72NisBJbcYhWokSnGH7
As suggested in AllskyTeam#5444: within a km or two is enough. 0.02 degrees keeps the real location within about 1.3 km instead of about 6 km with one decimal place, and the values still have 2 decimals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCB72NisBJbcYhWokSnGH7
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCB72NisBJbcYhWokSnGH7
2fb7c3e to
15acc65
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCB72NisBJbcYhWokSnGH7
…ocation # Conflicts: # docs/source/allsky_guide/changelog.md # html/docs/allsky_guide/changelog.html
… changelog As agreed with Eric, this PR now only adds "Hide Exact Location". The installer's Allsky Map prompt and the "showonmapdeclined" setting are removed, since the prompt will move to the WebUI. The changelog is no longer updated, so the new setting is described in the v2026.10.01_02 upgrade notes instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WCB72NisBJbcYhWokSnGH7

Closes #5436.
Update: As discussed with Eric, this PR now only adds "Hide Exact Location". The installer's Allsky Map prompt and its
showonmapdeclinedsetting are removed, since the prompt will move to the WebUI (#5444). The changelog is no longer updated, so the new setting is described in the v2026.10.01_02 upgrade notes instead.Hide Exact Location
hideexactlocationsits right after ==Latitude== and ==Longitude==.getPublicLatLong()infunctions.sh(convertLatLong plus rounding, locale-safe) is the one place this is calculated. It's used by:postToMap.sh, every time it runs;makeChanges.sh, forlatitude/longitudeand for the newhideexactlocationcase, which updates both values in the configuration.json files and uploads the remote one;replace_website_placeholders(), when a new Website configuration file is created.postToMap.shalso sends the whole settings file and the Website configuration to the map server, and both contain the exact location. When the setting is on, the location in that copy is replaced by the rounded values.update_all_settings_files()), since there's only one map entry per Pi.Not changed
${LATITUDE}/${LONGITUDE}(mentioned in the docs).allsky_shared.py.Docs
settings/allsky.md: new row; the Longitude text now points to the setting instead of "change the values slightly".howtos/allsky_map.md: new section "Hiding your exact location".upgrade/v2026.10.01_02.md: a "NEW" card under Settings.html/docsI only patched the changed content, because a full mkdocs build changes the navigation of many pages.Testing
getPublicLatLong: tested with signed and NSEW values, a comma decimal point, and a German locale.public_locationinpostToMap.sh: tested with a settings file and a configuration.json.bash -npasses on all changed scripts. ShellCheck has no new warnings.🤖 Generated with Claude Code
https://claude.ai/code/session_01WCB72NisBJbcYhWokSnGH7