feat/material-paper-extractor - #131
Open
shiyuasuka wants to merge 1 commit into
Open
shiyuasuka wants to merge 1 commit into
shiyuasuka wants to merge 1 commit into
Conversation
ethan7zhanghx
requested changes
Apr 24, 2026
ethan7zhanghx
left a comment
Collaborator
There was a problem hiding this comment.
阻塞性问题
Step 1 外部依赖缺失(详见 inline 评论)。
建设性建议(非阻塞性问题,可合入后再进行优化)
conda activate thl 在 Step 4 和 Step 8 中是多余的(两个脚本仅使用标准库),可直接用 python3 调用,建议清理。
业务相关性
本 skill 聚焦于从合金研究论文中提取材料科学数据,方向上与本仓库其他 skill 有所差异。如果这确实是本部门的业务需求,请忽略此评论;如果不在本仓库的收录范围内,可以考虑迁移到更合适的仓库。如有误解非常抱歉。
Co-reviewed with Claude
| --file-path "{pdf_path}" \ | ||
| --output "{output_base}/01_ocr/{id}.json" \ | ||
| --pretty | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Step 1 依赖 ~/.claude/skills/paddleocr-doc-parsing,但该 skill 在本仓库及所有分支中均不存在,其他用户无法运行 Step 1。请补充该依赖的安装或获取说明,或在仓库内一并提交。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更信息
本次变更内容
material-paper-extractorSkill,实现从材料科学 PDF 论文中提取结构化 JSON 数据的完整 8 步流水线scripts/04-validate.py:自动校验 JSON Schema、成分总和、数值范围、YS ≤ UTS 等约束scripts/08-summarize.py:聚合多篇论文的修订结果,输出 JSON / CSV / 统计报告references/目录下的提取规则、审核、修订、评估、汇总等 Prompt 文件extract materials、parse alloy paper、材料数据提取、合金论文解析等验证方式
PADDLEOCR_DOC_PARSING_API_URL和PADDLEOCR_ACCESS_TOKEN环境变量extract materials或材料数据提取,确认 Skill 被正确加载scripts/04-validate.py,确认验证脚本对合法 JSON 返回 Exit 0,对错误数据返回 Exit 1补充说明
{comparison_path}时执行Agent 提交备注
devdev提 PR 到main