chore(demo): remove .evolve dir from workspace and ignore globally#146
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughModified Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dir was accidentally committed in a26429d (AgentToolkit#138). Expand .gitignore pattern from /.evolve to .evolve so it is ignored in subdirs too.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.gitignore (1)
15-15: Scope of ignore rule is now too broad for.evolveruntime entity dirs.At Line 15,
.evolveignores any.evolvepath at any depth. Based onplatform-integrations/claude/plugins/evolve-lite/lib/entity_io.py:1-50,platform-integrations/codex/plugins/evolve-lite/README.md:1-10, andtests/platform_integrations/test_codex.py:1-20, nested.evolve/entitiespaths are valid user/runtime locations. This can silently prevent expected entity data from being tracked.Suggested narrow-scope ignore
-.evolve +/.evolve +# If only the demo workspace should be ignored, prefer: +# /demo/workspace/.evolve🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.gitignore at line 15, The .gitignore entry ".evolve" is too broad and ignores any .evolve directory at any depth (which hides valid runtime/entity dirs such as nested .evolve/entities referenced by platform-integrations/.../evolve-lite); update the pattern so it only ignores the top-level repository .evolve (e.g., change to a root-anchored pattern like "/.evolve" or "/.evolve/") so nested .evolve directories are not excluded, leaving all other .evolve paths (e.g., nested .evolve/entities) tracked.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.gitignore:
- Line 15: The .gitignore entry ".evolve" is too broad and ignores any .evolve
directory at any depth (which hides valid runtime/entity dirs such as nested
.evolve/entities referenced by platform-integrations/.../evolve-lite); update
the pattern so it only ignores the top-level repository .evolve (e.g., change to
a root-anchored pattern like "/.evolve" or "/.evolve/") so nested .evolve
directories are not excluded, leaving all other .evolve paths (e.g., nested
.evolve/entities) tracked.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 020dda68-4c45-490c-aa00-afa713e1ff5f
📒 Files selected for processing (3)
.gitignoredemo/workspace/.evolve/entities/guideline/on-macos-use-mdls-as-the-primary-tool-for-extracting-image.mddemo/workspace/.evolve/entities/guideline/when-running-exif-extraction-commands-use-a-fallback-chain.md
💤 Files with no reviewable changes (2)
- demo/workspace/.evolve/entities/guideline/on-macos-use-mdls-as-the-primary-tool-for-extracting-image.md
- demo/workspace/.evolve/entities/guideline/when-running-exif-extraction-commands-use-a-fallback-chain.md
Dir was accidentally committed in a26429d (#138). Expand .gitignore pattern from /.evolve to .evolve so it is ignored in subdirs too.
Summary by CodeRabbit
Chores
.evolveat any directory level.Documentation