Repository navigation
fix(db): allow access migrations on MariaDB - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hearth crashes during its access-permission migration on MariaDB because the audit insert uses MySQL's
CAST(? AS JSON). Coolify rolls back the deployment, leaving the previous panel running.Summary
Insert the already serialized JSON directly. Verify the persisted audit metadata and idempotent reruns in the existing migration fixture, and run that fixture against MariaDB 10.11 in CI alongside the existing MySQL coverage.
Notes
Reproduced the original SQL failure on MariaDB 10.11. The fixed fixture passes on MariaDB 10.11 and MySQL 8.4. Related migration tests, formatting, lint, syntax checks, and actionlint pass; Hearth loads in the development Preview.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.